Upstream: fix linkage on macOS 12 #75
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes prevent "dyld[678]: symbol not found in flat namespace" for several symbols. Xcode 13 and/or Monterey has stricter checks for undefined symbols. Note that binaries running on macOS 12, but built on macOS 11 with Xcode 12, don't trigger these checks for some reason.
Contributor
|
I believe it is due to ZOL moving to "-fvisibility=hidden" for libraries, which appears to be ignored (not supported?) in XCode 12. |
lundman
approved these changes
Jun 17, 2021
Contributor
Author
|
We'll need to check if these changes are still necessary (and if any other changes are needed) with macOS Monterey 12.0.1, which was released today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes prevent "dyld[678]: symbol not found in flat namespace"
for several symbols.
Xcode 13 and/or Monterey has stricter checks for undefined symbols. Note
that binaries running on macOS 12, but built on macOS 11 with Xcode 12,
don't trigger these checks for some reason.