vdev_disk: remove classic IO submission #17399
Merged
+4
−295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it was disabled for 2.3, there's been no confirmed sightings of
strange IO errors, misalignments or related shenanigans. Absence of
evidence and all that, but I'd rather fix bugs in the new code than in
the old.
"It isn't hubris until he's failed."
-- Chrisjen Avasarala
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Signed-off-by: Rob Norris <[email protected]>
amotin
approved these changes
May 29, 2025
|
Side note: classic mode appears be broken when running the 2.2.x branch on Fedora (#17392 (comment)) so it's removal is not only a cleanup but a bugfix. |
tonyhutter
approved these changes
May 29, 2025
amotin
added
Status: Accepted
Confirmed - it's broken in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sponsors: Klara, Inc., Wasabi Technology, Inc.]
Motivation and Context
Since it was disabled for 2.3, there's been no confirmed sightings of strange IO errors, misalignments or related shenanigans. Absence of evidence and all that, but I'd rather fix bugs in the new code than in the old.
Description
Rip out the code and the tunable. The end.
How Has This Been Tested?
Compiled and sanity checked (create pool, fio run, export, import, scrub).
Types of changes
Checklist:
Signed-off-by.