linux/zvol_os: don't try to set disk ops if alloc fails #17396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the kernel fails to allocate the gendisk, zvo_disk will be NULL, and derefencing it will explode. So don't do that. Sponsored-by: Klara, Inc. Signed-off-by: Rob Norris <[email protected]>
amotin
approved these changes
May 29, 2025
tonyhutter
approved these changes
May 29, 2025
tonyhutter
added
Status: Accepted
behlendorf
approved these changes
May 29, 2025
|
Any idea when next release might be to get one cut with this inside it? |
|
I'll pull this fix in to the next 2.2.x and 2.3.x releases. We're finalizing 2.2.8 now. |
behlendorf
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jun 3, 2025
If the kernel fails to allocate the gendisk, zvo_disk will be NULL, and derefencing it will explode. So don't do that. Sponsored-by: Klara, Inc. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes openzfs#17396
|
Gotchya. Any eyes on a 2.3.3 timeline? Apologies to be pushy just have some hosts we'd like to patch since we, on very rare occasions, have run into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sponsors: Klara, Inc.]
Motivation and Context
Just a trivial crasher noticed during experimenting.
If the kernel fails to allocate the gendisk,
zvo_diskwill beNULL, and derefencing it will explode.Description
Don't do that.
How Has This Been Tested?
By hand. No trivial reproducer; exhausting kernel memory is pretty niche. But it's an obvious bug.
Types of changes
Checklist:
Signed-off-by.