-
Notifications
You must be signed in to change notification settings - Fork 93
[fix] Remove global CSS rules to avoid conflicts #303 Refactored CSS to prevent global styling conflicts with downstream projects. Fixes #303 #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 8 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
47dabc9
Fixing global css issue
Unnati-Gupta24 2960928
Fixing global css issue
Unnati-Gupta24 489d344
[fix] Refactor CSS to avoid global style declarations #303
Unnati-Gupta24 a545b1c
[fix] Remove global CSS rules to avoid conflicts with downstream proj…
Unnati-Gupta24 a117764
[fix] Remove global CSS rules to avoid conflicts with downstream proj…
Unnati-Gupta24 068d66e
[fix] Remove global CSS rules to avoid conflicts #303
Unnati-Gupta24 5d78f63
Merge branch 'master' into master
Unnati-Gupta24 e83e9b0
[fix] Remove global CSS rules to avoid conflicts #303
Unnati-Gupta24 699408b
[deps] Bump eslint-config-prettier from 9.1.0 to 10.0.1
dependabot[bot] 58d9474
[[ci] Updated commit message prefix of dependabot
nemesifier ae4e765
[deps] Updated ECharts to version 5.6.0 #224 #305
dee077 203bc1c
[docs] Updated badges
nemesifier b0ade05
[docs] Improved run tests section
nemesifier d49c1ba
[deps] Bump @babel/preset-env from 7.26.0 to 7.26.9
dependabot[bot] 6e917e8
[tests] Added more options for selenium browser testing
nemesifier 7d45154
[ci] Added install-chromedriver: true
nemesifier 1537731
[ci] Added more chromedriver headless options
nemesifier f414642
[ci] ChromeDriver changes
nemesifier fde1561
[ci] Run on ubuntu-latest
nemesifier 1af5fd6
[ci] Use latest python version available on the system
nemesifier d1e927c
[tests] Simplified headless options
nemesifier 50fc6e0
[ci] Updated Build & Deploy step
nemesifier 1d606a7
[ci] Set timeout to browser tests
dee077 a0cc547
[deps] Bump webpack from 5.97.1 to 5.98.0
dependabot[bot] 702509b
[deps] Bump prettier from 3.4.2 to 3.5.2
dependabot[bot] 48624fd
[deps] Bump eslint-config-prettier from 10.0.1 to 10.0.2
dependabot[bot] 9b41567
[deps] Bump terser-webpack-plugin from 5.3.11 to 5.3.12
dependabot[bot] 354b663
[deps] Bump copy-webpack-plugin from 12.0.2 to 13.0.0
dependabot[bot] caf6c9d
[chores] Minor CSS refactoring
cestercian 686049b
Fixing global css issue
Unnati-Gupta24 deae5d5
Fixing global css issue
Unnati-Gupta24 3c1f4e9
[fix] Refactor CSS to avoid global style declarations #303
Unnati-Gupta24 5edc590
[fix] Remove global CSS rules to avoid conflicts with downstream proj…
Unnati-Gupta24 ab00f99
[fix] Remove global CSS rules to avoid conflicts with downstream proj…
Unnati-Gupta24 f2ee4cc
[fix] Remove global CSS rules to avoid conflicts #303
Unnati-Gupta24 aa34a17
[fix] Remove global CSS rules to avoid conflicts #303
Unnati-Gupta24 dd64a76
[fix] remove golbal css fixes #303
Unnati-Gupta24 3a4127b
[fix] Remove global CSS rules to avoid conflicts with downstream proj…
Unnati-Gupta24 1e7b863
[fix] Remove global CSS rules to avoid conflicts #303
Unnati-Gupta24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -14,6 +14,13 @@ | |||||||||||
<link href="../lib/css/netjsongraph-theme.css" rel="stylesheet" /> | ||||||||||||
<link href="../lib/css/netjsongraph.css" rel="stylesheet" /> | ||||||||||||
<style type="text/css"> | ||||||||||||
html, body { | ||||||||||||
margin: 0; | ||||||||||||
padding: 0; | ||||||||||||
height: 100%; | ||||||||||||
width: 100%; | ||||||||||||
} | ||||||||||||
|
||||||||||||
#legend h4 { | ||||||||||||
margin: 10px 0; | ||||||||||||
text-align: center; | ||||||||||||
|
@@ -68,9 +75,13 @@ | |||||||||||
</style> | ||||||||||||
</head> | ||||||||||||
<body> | ||||||||||||
<div class="netjsongraph-container"> | ||||||||||||
<div id="graphChartContainer"></div> | ||||||||||||
</div> | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we shorten this a bit, eg?
Suggested change
The |
||||||||||||
<script type="text/javascript"> | ||||||||||||
const map = new NetJSONGraph("../assets/data/netjsonmap.json", { | ||||||||||||
render: "map", | ||||||||||||
container: "#graphChartContainer", | ||||||||||||
clustering: true, | ||||||||||||
clusteringThreshold: 50, | ||||||||||||
// set map initial state. | ||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid repeating this in each example. We can make a CSS file and store it in
public/asstes/css/
, should be doable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya I'm making a separate file for example specific stylings