[fix] Allow variables in mac address patterns in schema.py#239
[fix] Allow variables in mac address patterns in schema.py#239lpalgarvio wants to merge 1 commit intoopenwisp:masterfrom
Conversation
|
tested as such: |
pandafy
left a comment
There was a problem hiding this comment.
Thank you contributing @lpalgarvio! I have left some suggestions below which will improve this PR.
Cool, ill try these and update as soon as possible :) |
Sorry for the delay! A bit overloaded with OpenWrt projects and other things :) |
|
Also maybe i should rename the commit to add "[fix]" to unbreak the CI checks |
pandafy
left a comment
There was a problem hiding this comment.
Thanks for following up @lpalgarvio! I have tested your patch with openwisp-controller and these changes work as expected.
I have asked for one more improvement below. After that we should be able to merge this. Let us know if you'll be able to fix it.
Also maybe i should rename the commit to add "[fix]" to unbreak the CI checks
@lpalgarvio you are correct. The QA checks of OpenWISP requires the commit messages in a specific format. Please read the contribution guidelines. Don't worry about squashing the commits, we'll handle that when we merge the PR.
fixed PR title, commit title and description, and because was already rebasing anyways to fix titles, squashed all commits |
…enwisp#238) - Adds BLANK and VAR patterns - Patches MAC patterns - Removes usage of maxLength and minLength in mac and bssid properties Co-authored-by: Gagan Deep <the.one.above.all.titan@gmail.com>
pandafy
left a comment
There was a problem hiding this comment.
Thank you very much for contributing @lpalgarvio! LGTM 👍🏼
Deferring merge to @nemesisdesign 😄
Closes #238