Add FloatingItemList + friends to Swift.#1662
Merged
Conversation
Having FloatingItemList + friends available on both Compose and SwiftUI helps harmonize the UI of a Multipaz app on both platforms. Port X509CertificateViewer.swift to use this rather than its own views. Also move all Swift sources to `multipaz-swiftui` folder and don't include this library in SwiftTestApp. Instead, add the Swift sources to the XCode project. This way it's possible to edit the sources in XCode and compilation is also faster. Also add "FloatingItemList examples" in both Compose Test App and Swift Test App to showcase how the various items work. Also add `trailingContent` to all items so it's possible to e.g. have buttons on the right side. Test: Manually tested. Signed-off-by: David Zeuthen <zeuthen@google.com>
davidz25
force-pushed
the
floating-item-sync
branch
from
659c5b1 to
be6a14d
Compare
sorotokin
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having FloatingItemList + friends available on both Compose and SwiftUI helps harmonize the UI of a Multipaz app on both platforms. Port X509CertificateViewer.swift to use this rather than its own views.
Also move all Swift sources to
multipaz-swiftuifolder and don't include this library in SwiftTestApp. Instead, add the Swift sources to the XCode project. This way it's possible to edit the sources in XCode and compilation is also faster.Also add "FloatingItemList examples" in both Compose Test App and Swift Test App to showcase how the various items work. Also add
trailingContentto all items so it's possible to e.g. have buttons on the right side.Test: Manually tested.