Conversation
sorotokin
approved these changes
Mar 26, 2026
davidz25
force-pushed
the
mpzpass-add-uuid
branch
4 times, most recently
from
990c30a to
27dd858
Compare
An unique identifier is needed so the wallet can check whether it has already imported a pass. Also put requirements on this identifier so it's strong enough to be used as an authentication token for updating the pass and add `version` and `updateUrl` as well to facilitate this. Spec out a simple update protocol but don't actually implement this yet since no remote issuer of Multipaz Passes currently exist. We may circle back and change that update protocol once we have some implementation experience. Also make `DocumentStore` aware of this identifier through a new property `Document.mpzPassId` and make `DocumentStore.importMpzPass` use this reuse the existing `Document` if it exists. Also updated the examples passes at https://apps.multipaz.org/mpzpass to have these new fields set. Test: New unit tests. Test: Manually tested by trying to import a pass twice. Signed-off-by: David Zeuthen <zeuthen@google.com>
davidz25
force-pushed
the
mpzpass-add-uuid
branch
from
27dd858 to
cbed4f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unique identifier is needed so the wallet can check whether it has already imported a pass. Also put requirements on this identifier so it's strong enough to be used as an authentication token for updating the pass and add
versionandupdateUrlas well to facilitate this. Spec out a simple update protocol but don't actually implement this yet since no remote issuer of Multipaz Passes currently exist. We may circle back and change that update protocol once we have some implementation experience.Also make
DocumentStoreaware of this identifier through a new propertyDocument.mpzPassIdand makeDocumentStore.importMpzPassuse this reuse the existingDocumentif it exists.Also updated the examples passes at https://apps.multipaz.org/mpzpass to have these new fields set.
Test: New unit tests.
Test: Manually tested by trying to import a pass twice.