-
Notifications
You must be signed in to change notification settings - Fork 2.4k
KWallet format: Support new partially-endianness-unbroken wallets, proper valid(), tunable costs, fix old KDF, support/produce truncated "hashes" #5869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
53e85b8
KWallet format: Support partially-endianness-unbroken wallets
solardiz 922d42d
KWallet format: Decrypt only first 64 bytes when we skip SHA-1
solardiz 6349fe7
KWallet format: Stricter valid()
solardiz b6d663a
KWallet format: Report tunable costs
solardiz 146d0ce
KWallet format: Add more test vectors
solardiz f5665de
KWallet format: Minor optimization, comments on bugs in old KDF
solardiz cf310fd
KWallet format: Fix the old KDF for multiples of 16 and >= 48
solardiz 98abfe1
KWallet format: Add more old KDF test vectors
solardiz 67219ab
KWallet format: Benchmark for short (up to 16) vs. long passwords (17+)
solardiz e79b08f
kwallet2john.py: Fix "invalid file structure" reporting
solardiz 566dbc9
KWallet format: Decrypt 56 bytes only, omit the SHA-1 check
solardiz f5fec25
KWallet format: Do not decode beyond 64 bytes, support truncation, unify
solardiz 0adfd40
kwallet2john.py: Produce truncated "hashes"
solardiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if using an older version of JtR would be an option given that there were a lot of cases which did not work at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Maybe I should add a warning to this comment, or drop the suggestion to comment-out for the old version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just revised the comment and force-pushed.