Skip to content

feat: GKR LogUp #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat: GKR LogUp #2

wants to merge 21 commits into from

Conversation

zlangley
Copy link
Contributor

No description provided.

@@ -65,7 +66,7 @@ where
type PartialProof = ();
type ProvingKey = StarkLogUpProvingKey;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this? I'm not sure if philosophically RAP phase should every require more information than the rest of the proving key provides

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm FRI logup does require it in the permutation trace generation. hmm it's kind of weird

Copy link
Contributor Author

@zlangley zlangley Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually only needed for FRI logug because FRI log up needs interaction chunk size (and GKR log up doesn't). GKR doesn't currently have any proving parameters.

@zlangley zlangley force-pushed the gkr-logup branch 7 times, most recently from e517748 to 63df013 Compare January 22, 2025 19:37
@zlangley zlangley marked this pull request as ready for review January 22, 2025 20:11
@zlangley zlangley force-pushed the gkr-logup branch 5 times, most recently from 0d51a2f to 1d74f44 Compare January 23, 2025 16:32
kunxian-xia added a commit that referenced this pull request Jan 26, 2025
* use p3-gpu

* use self-hosted ci runner

* use https instead of git url

* use github secret to fetch plonky3-gpu

* Revert "use https instead of git url"

This reverts commit 0b3343f3ece9b920644553e7e6101106ee620351.

* set CARGO_NET_GIT_FETCH_WITH_CLI

* Revert "set CARGO_NET_GIT_FETCH_WITH_CLI"

This reverts commit 7973118c3c221ffb7637750df641631f4562b6c0.

* add sppark deploy key
@jonathanpwang jonathanpwang changed the base branch from main to develop January 27, 2025 18:42
jonathanpwang pushed a commit that referenced this pull request Mar 9, 2025
jonathanpwang pushed a commit that referenced this pull request Mar 9, 2025
kunxian-xia added a commit that referenced this pull request Mar 26, 2025
* use p3-gpu

* use self-hosted ci runner
@zlangley zlangley force-pushed the gkr-logup branch 4 times, most recently from 5db1a33 to 7e057fc Compare April 10, 2025 14:27
@zlangley zlangley force-pushed the gkr-logup branch 2 times, most recently from 84ad8bf to 2548d06 Compare April 10, 2025 18:27
@zlangley zlangley changed the base branch from develop to main April 10, 2025 18:35
@zlangley zlangley force-pushed the gkr-logup branch 2 times, most recently from cdec90c to 4f2ee7d Compare April 10, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants