Skip to content

Conversation

@DeVikingMark
Copy link

Add OPENVM_GPU_TEST_PERSISTENT env var support to GpuChipTestBuilder::new().

Defaults to volatile memory for backward compatibility. Set to 1 to enable persistent mode.

@jonathanpwang
Copy link
Contributor

Not sure why we want this? It doesn't simplify any code

@DeVikingMark
Copy link
Author

Fair point. After thinking it through, for a while I've refactored to add new_persistent() method instead, matching the default_persistent() pattern in VmChipTestBuilder. This is more explicit and better I suppose.

@jonathanpwang jonathanpwang changed the title feat: add environment variable configuration for GpuChipTestBuilder::new() chore(test): add GpuChipTestBuilder::new_persistent Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants