feat: ability to verify e2e STARK proof + CLI command #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit: 4da0af9 |
nyunyunyunyu
requested changes
May 23, 2025
| @@ -322,6 +326,51 @@ impl<E: StarkFriEngine<SC>> GenericSdk<E> { | |||
| Ok(proof) | |||
| } | |||
|
|
|||
| pub fn verify_e2e_stark_proof( | |||
There was a problem hiding this comment.
Taking
openvm/crates/vm/src/arch/vm.rs
Line 735 in 4da0af9
| agg_stark_pk: AggStarkProvingKey, | ||
| proof: &VmStarkProof<SC>, | ||
| ) -> Result<[F; CHUNK]> { | ||
| let program_commit = |
There was a problem hiding this comment.
Check if all required AIRs are present. Otherwise .main_trace[PROGRAM_CACHED_TRACE_INDEX] could be about another AIR.
| @@ -322,6 +326,51 @@ impl<E: StarkFriEngine<SC>> GenericSdk<E> { | |||
| Ok(proof) | |||
| } | |||
|
|
|||
| pub fn verify_e2e_stark_proof( | |||
| &self, | |||
| agg_stark_pk: AggStarkProvingKey, | |||
There was a problem hiding this comment.
Pass a reference instead of a value.
| &self, | ||
| agg_stark_pk: AggStarkProvingKey, | ||
| proof: &VmStarkProof<SC>, | ||
| ) -> Result<[F; CHUNK]> { |
There was a problem hiding this comment.
Return AppExecutionCommit instead of just exe commit.
| .per_air | ||
| .iter() | ||
| .find(|p| p.air_id == PUBLIC_VALUES_AIR_ID) | ||
| .unwrap(); |
There was a problem hiding this comment.
Since this function returns a Result, throw an error instead of panic when PublicValueAir is absent.
| .unwrap(); | ||
| let pvs: &VmVerifierPvs<_> = | ||
| public_values_air_proof_data.public_values[..VmVerifierPvs::<u8>::width()].borrow(); | ||
|
|
There was a problem hiding this comment.
Check if program terminates with exit code = 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves INT-4064