Skip to content

fix: typos #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion audits/v1-internal/native-compiler.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ save columns, `RANGE_CHECK` is put into the existing `JalChip`.
**Context:** https://github.com/openvm-org/openvm/blob/336f1a475e5aa3513c4c5a266399f4128c119bba/extensions/native/compiler/src/conversion/mod.rs#L274

**Description:**
ASM compiler compiles `Assert*` DSL instructions into a conditional jump + a ASM instruction `Trap`, which only results a phantom instruction. The expolit can generate a valid execution trace which ignores all assertions in the program.
ASM compiler compiles `Assert*` DSL instructions into a conditional jump + a ASM instruction `Trap`, which only results a phantom instruction. The exploit can generate a valid execution trace which ignores all assertions in the program.

**Proof of concept:** N/A

Expand Down
2 changes: 1 addition & 1 deletion audits/v1-internal/poseidon2-air.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Author: https://github.com/MonkeyKing-1

Scope: Plonky3 poseidon2 and poseidon2 air

Understanding how the Plonky3 posiedon2 air works, make sure it is sound.
Understanding how the Plonky3 poseidon2 air works, make sure it is sound.

## 2. Findings

Expand Down
2 changes: 1 addition & 1 deletion crates/sdk/tests/integration_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const LEAF_LOG_BLOWUP: usize = 2;
const INTERNAL_LOG_BLOWUP: usize = 3;
const ROOT_LOG_BLOWUP: usize = 4;

/// `OpenVmHalo2Verifier` wraps the `snark-verifer` contract, meaning that
/// `OpenVmHalo2Verifier` wraps the `snark-verifier` contract, meaning that
/// the default `fallback` interface can still be used. This function uses
/// the fallback interface as opposed to the `verify(..)` interface.
fn verify_evm_halo2_proof_with_fallback(
Expand Down
2 changes: 1 addition & 1 deletion extensions/ecc/guest/src/weierstrass.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pub trait WeierstrassPoint: Sized {
/// coordinates are in little endian.
///
/// **Warning**: The memory layout of `Self` is expected to pack
/// `x` and `y` contigously with no unallocated space in between.
/// `x` and `y` contiguously with no unallocated space in between.
fn as_le_bytes(&self) -> &[u8];

/// Raw constructor without asserting point is on the curve.
Expand Down
2 changes: 1 addition & 1 deletion extensions/keccak256/circuit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

The `keccak-air` from Plonky3 is an AIR that does one `keccak-f[1600]` permutation every `NUM_ROUNDS = 24` rows (henceforth we call this the `keccak-f` AIR to avoid confusion). All rows in the round have the same `preimage`, which is the starting state prior to the permutation, represented as `5 * 5 * 4` `u16` limbs (the state in the spec is `5 * 5` `u64`s, but since the AIR uses a 31-bit field, the `u64` is broken into `u16`s).

The `keccak-f` permutation copies `preimage` to `A` and mutates `A` over rounds. The mutations are materialized in the `keccak-f` AIR in `A'` and `A''` arrays. While the bits of `A'` are materialized, the bits of `preimage` and `A` are never materialized (there is an implicit bit compostion in the constraints).
The `keccak-f` permutation copies `preimage` to `A` and mutates `A` over rounds. The mutations are materialized in the `keccak-f` AIR in `A'` and `A''` arrays. While the bits of `A'` are materialized, the bits of `preimage` and `A` are never materialized (there is an implicit bit composition in the constraints).

## Review of `keccak256` sponge

Expand Down
2 changes: 1 addition & 1 deletion extensions/native/compiler/src/ir/instructions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use serde::{Deserialize, Serialize};

use super::{Array, Config, Ext, Felt, MemIndex, Ptr, RVar, TracedVec, Usize, Var};

/// An intermeddiate instruction set for implementing programs.
/// An intermediate instruction set for implementing programs.
///
/// Programs written in the DSL can compile both to the recursive zkVM and the R1CS or Plonk-ish
/// circuits.
Expand Down
2 changes: 1 addition & 1 deletion extensions/native/recursion/src/fri/two_adic_pcs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ pub fn verify_two_adic_pcs<C: Config>(
let index_bits = challenger.sample_bits(builder, log_max_lde_height);

// We reset the reduced opening accumulator at the start of each query.
// We describe what `ro[log_height]` computes per query in pseduo-code, where `log_height`
// We describe what `ro[log_height]` computes per query in pseudo-code, where `log_height`
// is log2 of the size of the LDE domain: ro[log_height] = 0
// alpha_pow[log_height] = 1
// for round in rounds:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ impl FinalExp for Bls12_381 {

root = f.exp_bytes(true, &exp.to_bytes_be());
let three_be = three.to_bytes_be();
// NOTE[yj]: we can probably remove this first check as an optimization since we initizlize
// NOTE[yj]: we can probably remove this first check as an optimization since we initialize
// order_3rd_power to 0
if root == Fq12::ONE {
order_3rd_power = 0;
Expand Down
2 changes: 1 addition & 1 deletion extensions/pairing/guest/src/pairing/final_exp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pub trait FinalExp {
type Fp12: Field + FieldExtension<Self::Fp2>;

/// Assert in circuit that the final exponentiation is equal to one. The actual final
/// exponentiaton is calculated out of circuit via final_exp_hint. Scalar coefficients
/// exponentiation is calculated out of circuit via final_exp_hint. Scalar coefficients
/// to the curve points must equal to zero, which is checked in a debug_assert.
fn assert_final_exp_is_one(
f: &Self::Fp12,
Expand Down
2 changes: 1 addition & 1 deletion extensions/sha256/circuit/src/sha256_chip/air.rs
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ impl Sha256VmAir {
.when(next.inner.flags.is_first_4_rows)
.assert_eq(not(next.control.padding_occurred), is_next_not_padding);

// `pad_flags` is `*LastRow` on the row that contsrains the last four words of the message
// `pad_flags` is `*LastRow` on the row that constrains the last four words of the message
builder
.when(next.inner.flags.is_last_block)
.assert_eq(is_next_4th_row, is_next_last_padding);
Expand Down