feat: CLI prove use bin name for output path #1675
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh-axiom-xyz
requested review from
luffykai,
nyunyunyunyu and
jonathanpwang
luffykai
reviewed
May 23, 2025
| Options `--manifest-path`, `--target-dir` are also available to `verify`. If you omit `--app_vk` and/or `--proof`, the command will search for those files at `${target_dir}/openvm/app.vk` and `./app.proof` respectively. | ||
| Options `--manifest-path`, `--target-dir` are also available to `verify`. If you omit `--app_vk` the command will search for the verifying key at `${target_dir}/openvm/app.vk`. | ||
|
|
||
| If you omit `--proof`, the command will search the working directory for files with the `.app.proof` extension. Note that for this default case a single proof is expected to be found, and `verify` will fail otherwise. |
There was a problem hiding this comment.
I think verify should always pass in --proof to be explicit
| Ok(committed_exe) | ||
| Ok(( | ||
| committed_exe, | ||
| exe_path.file_stem().unwrap().to_str().unwrap().to_string(), |
There was a problem hiding this comment.
maybe exe_path.file_stem().unwrap().to_string_lossy().into_owned()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves INT-4074. Primarily accomplishes the following:
cargo openvm proveoutputs proofs to${bin_name}.app.proofinstead ofapp.proof, wherebin_nameis the file stem of the executable (same forstarkandevm)cargo openvm verifyby default searches the working directory for files with extension.app.proofAdditionally, the following are also in this PR:
cargo openvm init ${dir}creates directorydirif it doesn't already exist