Skip to content

feat: benchmarks for new execution #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
03e5df3
feat: implement execute traits for native adapters
shuklaayush May 13, 2025
f144897
fix: clippy
shuklaayush May 13, 2025
cafd4ba
feat: update castf
shuklaayush May 13, 2025
7931b9f
Merge remote-tracking branch 'origin/feat/new-execution' into feat/ne…
shuklaayush May 19, 2025
cbfa055
fix: castf chip
shuklaayush May 19, 2025
ca34e51
fix: adapter fixes
shuklaayush May 19, 2025
0897131
fix: get tests to run
shuklaayush May 20, 2025
f14397b
fix: native jal
shuklaayush May 20, 2025
8568806
fix: wip loadstore
shuklaayush May 20, 2025
70b2015
fix: native loadstore
shuklaayush May 20, 2025
70b5439
fix: native loadstore
shuklaayush May 20, 2025
a456561
fix: add fri chip
shuklaayush May 20, 2025
4649d28
feat: fri chip
shuklaayush May 20, 2025
53613c1
Merge remote-tracking branch 'origin/feat/new-execution' into feat/ne…
shuklaayush May 20, 2025
ceb679d
fix: add e2 execute methods
shuklaayush May 20, 2025
7f7535a
fix: add back execute_metered
shuklaayush May 20, 2025
642ce02
At least benchmarks compile now
Golovanov399 May 20, 2025
7568a87
`cargo fmt`
Golovanov399 May 20, 2025
30e5f99
Make it compile again after rebase + `cargo fmt`
Golovanov399 May 20, 2025
0a4c338
Merge branch 'feat/new-execution' into feat/new-execution-benchmarks-2
Golovanov399 May 21, 2025
bc47684
Kinda patch small segments issue
Golovanov399 May 21, 2025
43605a5
Merge branch 'feat/new-execution' into feat/new-execution-benchmarks-2
Golovanov399 May 21, 2025
a3a2a67
`cargo fmt`
Golovanov399 May 21, 2025
c054cc0
Fix memory
Golovanov399 May 21, 2025
7e6551e
Merge branch 'feat/new-execution' into feat/new-execution-benchmarks-2
Golovanov399 May 22, 2025
b5147ea
Merge branch 'feat/new-execution' into feat/new-execution-benchmarks-2
Golovanov399 May 23, 2025
d66e3d1
Add Native Poseidon2 chip
nyunyunyunyu May 23, 2025
d63c0e1
Merge branch 'feat/new-execution' into feat/new-execution-benchmarks-2
Golovanov399 May 24, 2025
8953fd1
Return weierstrass
Golovanov399 May 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/vm/src/arch/vm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ where
let metrics = segment.metrics.partial_take();

// TODO(ayush): this can probably be avoided
let memory = segment.ctrl.final_memory.as_ref().unwrap().clone();
let memory = segment.ctrl.final_memory.clone().unwrap();
Ok(VmExecutorOneSegmentResult {
segment,
next_state: Some(VmState {
Expand Down
1 change: 1 addition & 0 deletions extensions/rv32im/circuit/src/load_sign_extend/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ fn into_limbs<const NUM_LIMBS: usize, const LIMB_BITS: usize>(num: u32) -> [u32;

fn create_test_chip(tester: &mut VmChipTestBuilder<F>) -> Rv32LoadSignExtendChip<F> {
let range_checker_chip = tester.memory_controller().range_checker.clone();

Rv32LoadSignExtendChip::<F>::new(
VmAirWrapper::new(
Rv32LoadStoreAdapterAir::new(
Expand Down
Loading