feat: traits for generalized E3 #1664
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+294
to
+295
| // PERF: needless conversion | ||
| let local_opcode = BaseAluOpcode::from_usize(record.local_opcode as usize); |
There was a problem hiding this comment.
We do this in almost all the chips to assert that the opcode provided is valid. I am for letting the chips assume the opcode is valid and removing the unnecessary conversions from all the chips.
Comment on lines
+175
to
176
| /// fill in the rest of the row. This function will be called for each row in the trace which | ||
| /// being used, and all other rows in the trace will be filled with zeroes. |
There was a problem hiding this comment.
Suggested change
| /// fill in the rest of the row. This function will be called for each row in the trace which | |
| /// being used, and all other rows in the trace will be filled with zeroes. | |
| /// fill in the rest of the row. This function will be called for each row in the trace which | |
| /// is being used, and for all other rows in the trace see `fill_dummy_trace_row`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is targeting a new branch
feat/new-execution-e4which we should merge intofeat/new-executiononly after we get everything compiling again.Review this only after all E1/2/3 tasks are resolved and "E4" becomes a blocker.
This PR introduces the traits necessary to unify E3 and what we were formerly calling E4 into a single E3 generic over a new concept of
RecordArena. BasicallyRecordArenais a virtual allocator for records, which is backed by either theRowMajorMatrixitself or a more compact raw byte buffer (the latter is for hardware acceleration purposes).As discussed offline, the
NewVmChipWrapperstruct no longer makes sense and we should moveRecordArenaparts intoCTX. For now I made do by making some traits specific to RowMajorMatrix-backed arenas -- these can be changed later as needed.I included one example of
Rv32BaseAluall compiled and working. Unfortunately everything else no longer compiles.My thinking is we can merge this first and then @arayikhalatyan can speed-run the switching of most of the traits to get everything compiling again, and then we can re-run tests to make everything still works. (The alternative to get things to compile incrementally seems more painful?)
closes INT-3969