refactor: guest bindings #1613
Open
refactor: guest bindings #1613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg-final
branch
5 times, most recently
from
1027e21 to
88bf100
Compare
| @@ -26,11 +29,15 @@ To [leverage](./overview.md) compile-time known moduli for performance, you decl | |||
| ```rust | |||
| moduli_declare! { | |||
| Bls12_381Fp { modulus = "0x1a0111ea397fe69a4b1ba7b6434bacd764774b84f38512bf6730d2a0f6b0f6241eabfffeb153ffffb9feffffffffaaab" }, | |||
| Bn254Fp { modulus = "21888242871839275222246405745257275088696311157297823662689037894645226208583" }, | |||
| Bn254Fp { | |||
| modulus = "21888242871839275222246405745257275088696311157297823662689037894645226208583", impl_field = true | |||
There was a problem hiding this comment.
see my comment in the old PR on impl_field auto detection
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg-final
branch
8 times, most recently
from
56207ac to
63931ab
Compare
jonathanpwang
force-pushed
the
feat/binding-primitive-libs
branch
from
2a47052 to
c9c0989
Compare
jonathanpwang
force-pushed
the
refactor/guest-library-reorg-final
branch
from
63931ab to
6fbc163
Compare
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg-final
branch
from
cd66383 to
828553b
Compare
This comment has been minimized.
This comment has been minimized.
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg-final
branch
from
56c28d0 to
1d30696
Compare
This comment has been minimized.
This comment has been minimized.
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg-final
branch
2 times, most recently
from
fabaddf to
656670c
Compare
Base automatically changed from
feat/binding-primitive-libs
to
release-v1.2.1-rc.0
May 13, 2025 01:23
jonathanpwang
force-pushed
the
refactor/guest-library-reorg-final
branch
from
656670c to
bea1fb1
Compare
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg-final
branch
from
bea1fb1 to
4357ece
Compare
This reverts commit 27e82aa.
This reverts commit 18c1146.
It's nice for UX if the user didn't have to specify `impl_field = true` when declaring prime moduli using the `moduli_declare!` macro. To this end, this PR does the primality check in the macro. We use the `num_prime` crate for its `is_prime` function.
The ECC point decompression logic was previously implemented using hinting. But recently, a modular sqrt instruction (which also uses hinting) was added to the algebra extension. This created the opportunity to implement ECC point decompression using the sqrt method. More specifically, we can now simply compute $x^3 + a x + b$ as a modular integer and then take its sqrt to decompress a point. This PR implements decompression using the new sqrt instruction. Notes: - the hint_decompress and hint_non_qr phantom instructions were deleted - the invalid hint decompress test was deleted since it is no longer relevant
Avaneesh-axiom
force-pushed
the
refactor/guest-library-reorg-final
branch
from
ea95b66 to
6eb62ad
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: cde4242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes parts of the guest libraries for each extension. These libraries are to be moved into a new repo as part of the guest library re-org.
Summary of changes for each extension:
halo2curves_shimsmodule, along with a minimal set of constants remain in the openvm repo, while the bn254 and bls12_381 implementations were moved outsha256andset_sha256functions were deleted, leaving behind only the Rust bindingkeccak256andset_keccak256functions were deleted, leaving behind only the Rust bindingNotes:
mod_sqrtimplementation was moved from the ecc extension to the algebra extensionBenchmarks and examples are now outdated since they depend on guest libraries that no longer exist. These need to be redesigned and rewritten to use the new guest libraries. I wasn't able to easily port the benchmarks and examples because depending on the new guest libraries creates weird linker issues (I'm guessing due to double-importing openvm).
TODO:
Closes INT-3788