JS API: Add support for importModel(tensor) #32925
Open
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the JavaScript API to support importing models directly from Tensor instances, mirroring a recently added C++ API overload. The implementation adds tensor detection logic to the existing import_model method and includes test coverage for the new functionality.
Key Changes:
- Added tensor parameter detection and handling in CoreWrap::import_model
- Created test case validating the new tensor-based import API
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bindings/js/node/src/core_wrap.cpp | Added tensor overload detection and implementation in import_model method |
| src/bindings/js/node/tests/test_import_model_tensor.js | Added test verifying tensor-based model import functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for calling core.importModel(tensor) in the JavaScript API.
The new overload allows importing a model directly from a TensorWrap instance.
The change mirrors the recently added C++ overload of ov::Core::import_model(const ov::Tensor&).
Changes included:
Issue: #32725