Cache Minja Chat Template#4133
Open
apaniukov wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an in-memory cache for compiled Minja chat templates inside TokenizerImpl to avoid repeatedly constructing/parsing the same template during apply_chat_template(), significantly reducing per-call overhead in chat-template application.
Changes:
- Introduced a small (size-limited) cache of
minja::chat_templateobjects keyed by template string, guarded by a mutex. - Updated
apply_chat_template()to reuse cached templates and added locking around chat-template getters/setters to avoid data races. - Cleared the cache on
set_chat_template()to prevent reuse of stale compiled templates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/cpp/src/tokenizer/tokenizer_impl.hpp |
Adds mutex + unordered_map members for a Minja chat-template cache and declares a private cache accessor. |
src/cpp/src/tokenizer/tokenizer_impl.cpp |
Implements cached template retrieval and updates chat-template application and setters/getters to use locking and the cache. |
yatarkan
approved these changes
Jul 10, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid huge fix costs from chat template re-reading:
Before:
After:
CVS-189192
Fixes #(issue)
Checklist: