-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCP/PROTO: Disable protocols that need memory type copy #10490
base: master
Are you sure you want to change the base?
Changes from all commits
5dedabe
545bbee
943d3e2
ecdb39e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -149,6 +149,7 @@ static void ucp_proto_amo_probe(const ucp_proto_init_params_t *init_params, | |
int is_memtype) | ||
{ | ||
ucp_worker_h worker = init_params->worker; | ||
ucs_memory_type_t send_mem_type = init_params->select_param->mem_type; | ||
ucs_memory_type_t reply_mem_type = | ||
init_params->select_param->op.reply.mem_type; | ||
ucp_proto_single_init_params_t params = { | ||
|
@@ -181,6 +182,12 @@ static void ucp_proto_amo_probe(const ucp_proto_init_params_t *init_params, | |
return; | ||
} | ||
|
||
if ((!UCP_MEM_IS_ACCESSIBLE_FROM_CPU(send_mem_type) || | ||
!UCP_MEM_IS_ACCESSIBLE_FROM_CPU(reply_mem_type)) && | ||
init_params->worker->context->config.ext.avoid_copy_mem_types) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe you can disable it only for non-host memtypes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be fixed now |
||
return; | ||
} | ||
|
||
if (op_id != UCP_OP_ID_AMO_POST) { | ||
params.super.flags |= UCP_PROTO_COMMON_INIT_FLAG_RESPONSE; | ||
if (!UCP_MEM_IS_ACCESSIBLE_FROM_CPU(reply_mem_type) && | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -192,7 +192,8 @@ ucp_tag_rndv_offload_sw_proto_probe(const ucp_proto_init_params_t *init_params) | |
ucp_proto_rndv_ctrl_priv_t rpriv; | ||
|
||
if (!ucp_tag_rndv_check_op_id(init_params) || | ||
!ucp_ep_config_key_has_tag_lane(init_params->ep_config_key)) { | ||
!ucp_ep_config_key_has_tag_lane(init_params->ep_config_key) || | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add a simple mock test to verify the protocol selection? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. need to discuss because there are many protocols to tests in that case. |
||
init_params->worker->context->config.ext.avoid_copy_mem_types) { | ||
return; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to fix from my side, since we had agreed on naming, @yosefe @brminich shall we go ahead with
MEMTYPE_COPY_ENABLE
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to explain my comment. We have dozens UCX variables ended by "ENABLE", but with "AVOID". And I think it is inconvenient to set a negative value to a variable with a negative in the name to enable a feature.