CONTRIB/MOCK: Address review comments

openucx · Feb 5, 2025 · bcfdc42 · bcfdc42
1 parent c26675b
commit bcfdc42
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/test/gtest/ucp/test_ucp_perf.cc b/test/gtest/ucp/test_ucp_perf.cc
@@ -327,18 +327,18 @@ UCS_TEST_SKIP_COND_P(test_ucp_perf, envelope, has_transport("self"))
     size_t max_iter = std::numeric_limits<size_t>::max();
     test_spec test  = tests[get_variant_value(VARIANT_TEST_TYPE)];
 
-    std::stringstream ss;
-    ss << GetParam().transports;
-
     if (ucs::is_aws() && (test.wait_mode == UCX_PERF_WAIT_MODE_SLEEP) &&
-        ss.str() == "ud_v") {
+        has_transport("ud_v")) {
+        // TODO support wakeup in UD transport without requiring IBV_SEND_SOLICITED
         UCS_TEST_SKIP_R("wait mode sleep on EFA not available on UD");
     }
 
     if (has_transport("tcp")) {
         max_iter   = 1000lu;
     }
 
+    std::stringstream ss;
+    ss << GetParam().transports;
     /* coverity[tainted_string_argument] */
     ucs::scoped_setenv tls("UCX_TLS", ss.str().c_str());
     ucs::scoped_setenv warn_invalid("UCX_WARN_INVALID_CONFIG", "no");