Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly calculate elevation profile for partial street edges #2752

Closed
wants to merge 6 commits into from

Conversation

evansiroky
Copy link
Contributor

@evansiroky evansiroky commented Apr 23, 2019

This PR correctly calculates the way elevation profiles are calculated for partial street edges. This feature was authored primarily by @demory and I am merely making a PR request to isolate this feature out of the work done in #2664. This feature was initially implemented in the PartialStreetEdge class which has since been deleted in dev-1.x, so I don't even know for sure if this is actually needed anymore.

  • issue: Link to or create an issue that describes the relevant feature or bug. Add GitHub keywords to this PR's description (e.g., closes #45).
  • roadmap: Check the roadmap for this feature or bug. If it is not already on the roadmap, PLC will discuss as part of the review process.
  • tests: Have you added relevant test coverage? Are all the tests passing on the continuous integration service (Travis CI)?
  • formatting: Have you followed the suggested code style?
  • documentation: If you are adding a new configuration option, have you added an explanation to the configuration documentation tables and sections?
  • changelog: add a bullet point to the changelog file with description and link to the linked issue

To be completed by @opentripplanner/plc:

  • reviews and approvals by 2 members, ideally from different organizations
  • after merging: update the relevant card on the roadmap

@evansiroky evansiroky requested a review from a team as a code owner April 23, 2019 23:39
@hannesj hannesj added the X OTP1 ~ Not in use any more ~ Fix or backport to the 1.x version of OTP label Nov 4, 2021
@leonardehrenfried
Copy link
Member

This has been fixed in OTP2 in #4033

Closing.

@leonardehrenfried leonardehrenfried deleted the partial-edge-elevation branch December 15, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X OTP1 ~ Not in use any more ~ Fix or backport to the 1.x version of OTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants