Skip to content

feat: Add Audio Transport Support to Websocket Implementation - #297

Open
superchilled wants to merge 4 commits into
mainfrom
feat-add-audio-transport-support-to-websocket
Open

feat: Add Audio Transport Support to Websocket Implementation#297
superchilled wants to merge 4 commits into
mainfrom
feat-add-audio-transport-support-to-websocket

Conversation

@superchilled

Copy link
Copy Markdown
Contributor

Since the WebSocket#connect method accepts a generic Hash of opts, the method already technically supports the new params. This PR therefore:

  • Updates an existing unit test for the method to include the new params
  • Updates the YARD doc comments for the method to include the new params

This PR completes https://jira.vonage.com/browse/DEVX-11297

@superchilled
superchilled requested a lite review from Copilot August 18, 2026 15:11
@vonage-ai-assistant

vonage-ai-assistant Bot commented Aug 18, 2026

Copy link
Copy Markdown

AI Code: 100%

AI Adoption Report

Lines %
AI-generated 3 100%
Human 0 0%
Untracked 24
Total 27

💰 Cost Breakdown

Agent Model AI Lines Input Tokens Output Tokens Cost Source
GitHub Copilot github-copilot 3 33 10 $0.0000 🤖 Copilot (subscription)

Total Estimated Cost: $0.0000

Data Sources:

  • 📐 1 commits with estimated tokens (~3.5 tokens/line)

Bedrock pricing: eu-central-1 region

Per-commit breakdown (4 commits)
Commit Message Added AI Human AI %
79b81df Potential fix for pull request finding 3 3 0 🤖 100% (Copilot)
2a8be8d snake casing audio_transport param name 7 untracked
e4ed79d Updating YARD doc comments for WebSocket#connect method 6 untracked
a01dee6 Updating unit test and mock 11 untracked

Warning

The following commits have no Git AI authorship notes — AI adoption cannot be tracked for these changes.
Install git-ai locally (curl -sSL https://usegitai.com/install.sh | bash) to enable automatic tracking.

  • 2a8be8d snake casing audio_transport param name
  • e4ed79d Updating YARD doc comments for WebSocket#connect method
  • a01dee6 Updating unit test and mock

Powered by Git AI Standard v3.0.0 — authorship data from refs/notes/ai (supports sessions-v2 format)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Ruby SDK’s Audio Connector WebSocket “connect” request surface area to reflect newly supported audio transport parameters, aligning tests and public documentation with the existing opts pass-through behavior.

Changes:

  • Extend the WebSocket connect unit test to include audio_transport options.
  • Update the recorded VCR cassette to match the new request body (audioTransport).
  • Document the new :audio_transport options in YARD for OpenTok::WebSocket#connect.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
spec/opentok/websocket_spec.rb Adds audio_transport options to the connect call opts in the unit test.
spec/cassettes/OpenTok_WebSocket/receives_a_valid_response_with_opts.yml Updates the expected JSON request body to include audioTransport.
lib/opentok/websocket.rb Adds YARD doc entries describing the new :audio_transport options.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/opentok/websocket.rb Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@vonage-ai-assistant vonage-ai-assistant Bot added the ai-generated Over 80% AI contribution label Aug 18, 2026
@superchilled superchilled removed the ai-generated Over 80% AI contribution label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants