feat: Add Audio Transport Support to Websocket Implementation - #297
feat: Add Audio Transport Support to Websocket Implementation#297superchilled wants to merge 4 commits into
Conversation
AI Adoption Report
💰 Cost Breakdown
Total Estimated Cost: $0.0000
Per-commit breakdown (4 commits)
Warning The following commits have no Git AI authorship notes — AI adoption cannot be tracked for these changes.
Powered by Git AI Standard v3.0.0 — authorship data from |
There was a problem hiding this comment.
Pull request overview
This PR updates the Ruby SDK’s Audio Connector WebSocket “connect” request surface area to reflect newly supported audio transport parameters, aligning tests and public documentation with the existing opts pass-through behavior.
Changes:
- Extend the WebSocket connect unit test to include
audio_transportoptions. - Update the recorded VCR cassette to match the new request body (
audioTransport). - Document the new
:audio_transportoptions in YARD forOpenTok::WebSocket#connect.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/opentok/websocket_spec.rb | Adds audio_transport options to the connect call opts in the unit test. |
| spec/cassettes/OpenTok_WebSocket/receives_a_valid_response_with_opts.yml | Updates the expected JSON request body to include audioTransport. |
| lib/opentok/websocket.rb | Adds YARD doc entries describing the new :audio_transport options. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Since the
WebSocket#connectmethod accepts a generic Hash ofopts, the method already technically supports the new params. This PR therefore:This PR completes https://jira.vonage.com/browse/DEVX-11297