Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow poetry 2.0.X #91

Merged
merged 8 commits into from
Jan 14, 2025
Merged

chore: allow poetry 2.0.X #91

merged 8 commits into from
Jan 14, 2025

Conversation

project-defiant
Copy link
Collaborator

@project-defiant project-defiant commented Jan 13, 2025

Context

With the new poetry release (2.0.X) there are a few things to update:

  1. The poetry export command does not work anymore without explicity adding the poetry-plugin-export as a dependency (can be added by pipx inject poetry poetry-plugin-export. This command was used to generate the python requirements.
  2. The structure of the pyproject.toml has changed to reflect the pypa specification. This means that we need to update the structure of pyproject.toml project and dependencies.
    The pyproject.toml can be checked with poetry check command.

Implementations

  • Added the poetry-plugin-export installation to the dev script with a way recommended by poetry documentation
  • Added the poetry-plugin-export to the pyproject.toml
  • Changed tool.poetry.project to project in pyproject.toml
  • FIxed authors field structure in project field in pyproject.toml
  • Dropped old entrypoint script from pyproject.toml
  • Added dynamic fields on dependencies and requires-python in pyproject.toml.

Requirements

This PR requires the fix done by @Daniel-Considine - in #90 to the github actions pycln

References

changes to the poetry 2.0.X

Copy link
Contributor

@ireneisdoomed ireneisdoomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the TOML having their own TOML in Poetry as a reference.
Changes look OK, although tests are failing. See if you have to change the dependencies syntax.

@project-defiant
Copy link
Collaborator Author

I updated the TOML having their own TOML in Poetry as a reference. Changes look OK, although tests are failing. See if you have to change the dependencies syntax.

I have not changed the dependencies syntax, just flagged them as dynamic, that way we have an uniform way of defining the dependencies for development and required by the package.\

Tests are failing due to the pycln, that was fixed by DC. See the description of the PR.

Thanks!

@project-defiant
Copy link
Collaborator Author

The PR was merged, tests are passing now

Copy link
Contributor

@ireneisdoomed ireneisdoomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@project-defiant project-defiant merged commit 38b1589 into dev Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants