-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow poetry 2.0.X #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the TOML having their own TOML in Poetry as a reference.
Changes look OK, although tests are failing. See if you have to change the dependencies syntax.
91fec40
to
ac1dcdd
Compare
I have not changed the dependencies syntax, just flagged them as dynamic, that way we have an uniform way of defining the dependencies for development and required by the package.\ Tests are failing due to the pycln, that was fixed by DC. See the description of the PR. Thanks! |
The PR was merged, tests are passing now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Context
With the new poetry release (2.0.X) there are a few things to update:
poetry export
command does not work anymore without explicity adding thepoetry-plugin-export
as a dependency (can be added bypipx inject poetry poetry-plugin-export
. This command was used to generate the python requirements.pyproject.toml
has changed to reflect the pypa specification. This means that we need to update the structure of pyproject.tomlproject
anddependencies
.The pyproject.toml can be checked with
poetry check
command.Implementations
poetry-plugin-export
installation to the dev script with a way recommended by poetry documentationpoetry-plugin-export
to the pyproject.tomltool.poetry.project
toproject
in pyproject.tomlproject
field in pyproject.tomldependencies
andrequires-python
in pyproject.toml.Requirements
This PR requires the fix done by @Daniel-Considine - in #90 to the github actions pycln
References
changes to the poetry 2.0.X