Remove field naming #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamzr
approved these changes
Sep 26, 2018
| <!-- Too agressive! For example serialNumberUUID is wrong --> | ||
| <exclude name="FieldNamingConventions" /> | ||
| <!-- misguided attempt to avoid boolean setter getter confusion --> | ||
| <exclude name="LinguisticNaming" /> |
There was a problem hiding this comment.
Really, this seems reasonable, what issues did we run into?
There was a problem hiding this comment.
It hit a lot of fp on david's stuff. As a general rule I'm being conservative on this stuff
| @@ -73,6 +73,10 @@ | |||
| <exclude name="GenericsNaming" /> | |||
| <!-- Way too picky @Goofy("star") vs @Goofy(value = "star") is ok --> | |||
| <exclude name="UnnecessaryAnnotationValueElement" /> | |||
| <!-- Too agressive! For example serialNumberUUID is wrong --> | |||
| <exclude name="FieldNamingConventions" /> | |||
There was a problem hiding this comment.
It's configurable, we could modify the regex patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New excessive rules in 6.7.0