add exclusions per scott #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamzr
reviewed
Jul 25, 2018
| @@ -71,6 +71,8 @@ | |||
| <exclude name="AvoidPrefixingMethodParameters" /> | |||
| <exclude name="ShortClassName" /> | |||
| <exclude name="GenericsNaming" /> | |||
| <!-- Way too picky @Goofy("star") vs @Goofy(value = "star") is ok --> | |||
| <exclude name="UnnecessaryAnnotationValueElement" /> | |||
There was a problem hiding this comment.
I like this rule, but agree that it's not worth failing the build over.
There was a problem hiding this comment.
Scott haf tthe issue th at some tool he has auto fills in value=
I like the rule too and like a lot of these... Lcd. You could overide yourself but that's a consistency nightmare
There was a problem hiding this comment.
I guess the question... why does this rule matter?
There was a problem hiding this comment.
doesn't, just stylistic, looks nicer w/o value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.