Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One UI PR to rule them all #517

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
dbc26c2
One UI PR to rule them all
narcolepticinsomniac Oct 12, 2018
586ad8a
edit
narcolepticinsomniac Oct 12, 2018
b2af877
usercss
narcolepticinsomniac Oct 12, 2018
525030c
prefs
narcolepticinsomniac Oct 12, 2018
6474eb1
manage CSS
narcolepticinsomniac Oct 12, 2018
4f45e63
messagebox
narcolepticinsomniac Oct 12, 2018
e83ff94
options CSS
narcolepticinsomniac Oct 12, 2018
9710876
popup
narcolepticinsomniac Oct 12, 2018
e4aaa9e
messages
narcolepticinsomniac Oct 12, 2018
9dfafe3
Reincorporate 8's updates
narcolepticinsomniac Oct 12, 2018
407e70b
Reincorporate 8's updates
narcolepticinsomniac Oct 12, 2018
f52fd0d
Reincorporate 8's updates
narcolepticinsomniac Oct 12, 2018
f76512e
Reincorporate 8's updates
narcolepticinsomniac Oct 12, 2018
0766dd7
Reincorporate tophf's update
narcolepticinsomniac Oct 12, 2018
d051bd3
Reincorporate 8's updates
narcolepticinsomniac Oct 12, 2018
5d73cbf
Reincorporate an updated line I missed
narcolepticinsomniac Oct 12, 2018
d1bc802
Reincorporate a line of code I missed
narcolepticinsomniac Oct 12, 2018
2d28a75
Remove usercss white styling
narcolepticinsomniac Oct 13, 2018
3c1ee1c
Tweaks
Mottie Oct 13, 2018
5df1380
Rearrange HTML & remove extra JS
Mottie Oct 13, 2018
d6104c8
Revert gutting theme detection inline styling
narcolepticinsomniac Oct 14, 2018
d2171dc
Don't hide dummy external icon when search opens
narcolepticinsomniac Oct 14, 2018
e1af6ee
Fix hover, disable all & icon position
Mottie Oct 14, 2018
be1d6fa
Update hover effect
Mottie Oct 14, 2018
5ecba47
Hide find styles link/icons on search
Mottie Oct 14, 2018
7a8ef95
Popup fixup
narcolepticinsomniac Oct 18, 2018
fff1d8d
Popup fixup
narcolepticinsomniac Oct 18, 2018
0949630
Eliminate gap on top of body
narcolepticinsomniac Oct 18, 2018
2753461
Fix manage icon
Mottie Oct 19, 2018
686c099
Restore original wiki icon
Mottie Oct 19, 2018
63a6098
Fixup usercss applies-to theme detection
narcolepticinsomniac Oct 19, 2018
2d63d93
Fixup errant paste
narcolepticinsomniac Oct 19, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reincorporate a line of code I missed
narcolepticinsomniac authored Oct 12, 2018
commit d1bc80282fe004a2d03a7ab29c435aa91b5d21a7
2 changes: 1 addition & 1 deletion popup/popup.js
Original file line number Diff line number Diff line change
@@ -172,7 +172,7 @@ function initPopup() {
$('label', info).textContent = t('unreachableAMO');
const note = (FIREFOX < 59 ? t('unreachableAMOHintOldFF') : t('unreachableAMOHint')) +
(FIREFOX < 60 ? '' : '\n' + t('unreachableAMOHintNewFF'));
const renderToken = s => s[0] === '<' ? $create('b', s.slice(1, -1)) : s;
const renderToken = s => s[0] === '<' ? $create('b', tWordBreak(s.slice(1, -1))) : s;
const renderLine = line => $create('p', line.split(/(<.*?>)/).map(renderToken));
const noteNode = $create('fragment', note.split('\n').map(renderLine));
const target = $('p', info);