Create WatcherAPI service #37
Conversation
cescgina
force-pushed
the
create_watcherapi_service
branch
from
bcade20 to
49ed65f
Compare
|
/hold we'll integrate watcherapi with the watcher controller before this PR |
cescgina
force-pushed
the
create_watcherapi_service
branch
from
49ed65f to
6bab6da
Compare
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2658 is needed. |
|
recheck |
cescgina
force-pushed
the
create_watcherapi_service
branch
5 times, most recently
from
cc708bb to
eaa1528
Compare
Create the WatcherAPI service. Adds new fields to the spec related to the service.
Temporary solution to expose the service while the operator is installed standalone. After we integrate watcher-operator with the openstack-operator, we'll rely on it to expose the services like the other do, and this code should be removed.
cescgina
force-pushed
the
create_watcherapi_service
branch
from
eaa1528 to
cebf135
Compare
|
/hold cancel |
|
/lgtm we will need to refactor this part of the CRDs once we integrate into openstack-operator. |
Use the Override spec field that is used in the other operators, so once we change the code to expose the services to use the same method used by the openstack operator, the spec will go through less changes.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bc592a6603fa4e2dafd500804322a1cf ✔️ noop SUCCESS in 0s |
|
recheck |
|
/approve thank you @cescgina! This looks good now. I will start working on enabling watcher tempest plugin api tests in validation job. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm I'd propose to validate key name sin override:service to be internal or public. I'm not sure if it is better to do it in webhooks or in controllerts, tbh. |
openshift-merge-bot
bot
merged commit 7466626
into
openstack-k8s-operators:main
+1 to use via webhooks. Here is how keystoneapi is validating it https://github.com/openstack-k8s-operators/keystone-operator/blob/main/api/v1beta1/keystoneapi_webhook.go#L124 . |
Create WatcherAPI service
Create the WatcherAPI service. Adds new fields to the spec related to the service, as well as functional and kuttl tests.
Related: OSPRH-11483
Depends-On: openstack-k8s-operators/ci-framework#2658