Skip to content

Conversation

@csibbitt
Copy link

@csibbitt csibbitt commented Dec 8, 2025

@openshift-ci openshift-ci bot requested review from olliewalsh and stuggi December 8, 2025 21:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csibbitt
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

name: accel-drivers
spec:
playbook: osp.edpm.accel_drivers
edpmServiceType: accel-drivers
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a several services (for example[1]) listing caCerts: combined-ca-bundle, which looks like it contains internal CAs. I'd like that for this service, so that it can verify certs on an internal https URL by default.

AFAICT, "combined-ca-bundle" should be the default[2], is there a reason it's repeated in so many service definitions or something I'm missing from my understanding? Should I be adding this here?

[1] https://github.com/openstack-k8s-operators/openstack-operator/blob/main/config/services/dataplane_v1beta1_openstackdataplaneservice_ovn.yaml#L23
[2] https://github.com/openstack-k8s-operators/openstack-operator/blob/main/api/bases/dataplane.openstack.org_openstackdataplaneservices.yaml#L37

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in my cloud and the defaults seem to apply just fine.

$ oc describe po accel-drivers-accel-drivers-deployment-openstack-edpm-ipam54rph | grep -B 3 combined-ca-bundle
    Mounts:
      /runner/env/ssh_key from ssh-key (rw,path="ssh_key")
      /runner/inventory/hosts from inventory (rw,path="inventory")
      /var/lib/openstack/cacerts/accel-drivers from accel-drivers-combined-ca-bundle (rw)
--
  ContainersReady             False 
  PodScheduled                True 
Volumes:
  accel-drivers-combined-ca-bundle:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  combined-ca-bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant