Modified CreateKeystoneAPI to take an additional parameter spec #526
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibizer
reviewed
Jan 23, 2025
This will fix all other operators func tests depending on CreateKeystoneAPI.
mrkisaolamb
force-pushed
the
mod-test-helper
branch
from
054729b to
976402d
Compare
|
Short trim I'm OK with this to stop the bleeding. Longer term we should be careful duplicating default values between the kubebuilder def and the envtest helper as it can easily lead to divergence between the two value and we will end up testing with what is not the default any more. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrkisaolamb, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 552fda9
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will fix all func tests in operators without any additional changes required.
Currently tests are failing in renovate bump patches openstack-k8s-operators/nova-operator#918 . Problem is with defaulting APITimeout, webhook is failing when spec is empty. Unfortunattly other option with using Unstruct is required much more changes inside the function and also in other operators test suite to add keystone defaulting