Add Product Image Display Support in Receiving and Sales Views #4292
+2,142
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed black line alignment problem where total columns extended beyond borders - Added dynamic colspan calculation to handle avatar column visibility - Updated all colspan values from hardcoded '3' to dynamic '' - Ensured proper alignment regardless of avatar column show/hide state - Standardized border styling from '#000000' to 'black' for consistency
- Added Turnstile configuration options in Config.php and Login.php. - Implemented database migration to add Turnstile keys.
jekkos
reviewed
Aug 1, 2025
| @@ -23,18 +23,75 @@ | |||
|
|
|||
| <?php if (ENVIRONMENT == 'development' || get_cookie('debug') == 'true' || $request->getGet('debug') == 'true') : ?> | |||
| <!-- inject:debug:css --> | |||
| <link rel="stylesheet" href="resources/css/jquery-ui-fe010342cb.css"> | |||
There was a problem hiding this comment.
this should be omitted from the PR
jekkos
reviewed
Aug 1, 2025
| database.default.password = 'pointofsale' | ||
| database.default.database = 'osposs' | ||
| database.default.username = 'root' | ||
| database.default.password = 'root' |
jekkos
reviewed
Aug 1, 2025
| } | ||
|
|
||
| $image = ''; | ||
| if (!empty($item->pic_filename)) { |
There was a problem hiding this comment.
seems indentation is not completely correct here.
jekkos
reviewed
Aug 1, 2025
|
|
||
| if (sizeof($images) < 2 && !file_exists($thumb_path)) { | ||
| { | ||
| helper('file'); |
There was a problem hiding this comment.
I would like to check these improvements, currently the thumbnail does not seem to be working
|
Thanks for this PR! looks like a nice addition, I'll try to install it on dev so I can try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the visual experience of OpenSourcePOS by adding product image display functionality across receiving and sales interfaces. Key changes include:
Technical Details:
Testing:
This enhancement improves product identification and verification during transactions while maintaining the system's performance and usability.