Skip to content

[release-4.14] OCPBUGS-47441: Bump x/net to v0.33.0 #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from

Conversation

mansikulkarni96
Copy link
Member

This commit bumps the x/net dependency to v0.33.0
to fix CVE-2024-45338.
Ran: go mod tidy && go mod vendor

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 29, 2025
@openshift-ci-robot
Copy link

@mansikulkarni96: This pull request references Jira Issue OCPBUGS-47441, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-47441 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit bumps the x/net dependency to v0.33.0
to fix CVE-2024-45338.
Ran: go mod tidy && go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sebsoto January 29, 2025 04:53
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mansikulkarni96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@mansikulkarni96
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@mansikulkarni96: This pull request references Jira Issue OCPBUGS-47441, which is invalid:

  • expected dependent Jira Issue OCPBUGS-47440 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mansikulkarni96 mansikulkarni96 changed the title OCPBUGS-47441: [release-4.13] Bump x/net to v0.33.0 OCPBUGS-47441: [release-4.14] Bump x/net to v0.33.0 Jan 29, 2025
@sebsoto sebsoto changed the title OCPBUGS-47441: [release-4.14] Bump x/net to v0.33.0 [release-4.14] OCPBUGS-47441: Bump x/net to v0.33.0 Feb 5, 2025
@jrvaldes
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@jrvaldes: This pull request references Jira Issue OCPBUGS-47441, which is invalid:

  • expected dependent Jira Issue OCPBUGS-47440 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mansikulkarni96
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 13, 2025
@openshift-ci-robot
Copy link

@mansikulkarni96: This pull request references Jira Issue OCPBUGS-47441, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-47440 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-47440 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @rrasouli

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from rrasouli May 13, 2025 17:48
@mansikulkarni96
Copy link
Member Author

/retest

@jrvaldes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b631b0a and 2 for PR HEAD 3fd99f4 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b631b0a and 2 for PR HEAD 3fd99f4 in total

@jrvaldes
Copy link
Contributor

/retest

@jrvaldes
Copy link
Contributor

@mansikulkarni96 I'm fine overriding the platform-none-vsphere-e2e-operator and vsphere-e2e-upgrade jobs, the vendor bump changes were tested/validated already in the other tests

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b631b0a and 2 for PR HEAD 3fd99f4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61a7222 and 1 for PR HEAD 3fd99f4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61a7222 and 2 for PR HEAD 3fd99f4 in total

@jrvaldes
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3afd66a and 1 for PR HEAD 3fd99f4 in total

@sebsoto
Copy link
Contributor

sebsoto commented May 15, 2025

/override "ci/prow/platform-none-vsphere-e2e-operator"

@sebsoto
Copy link
Contributor

sebsoto commented May 15, 2025

/override "Red Hat Konflux"

Copy link
Contributor

openshift-ci bot commented May 15, 2025

@sebsoto: Overrode contexts on behalf of sebsoto: ci/prow/platform-none-vsphere-e2e-operator

In response to this:

/override "ci/prow/platform-none-vsphere-e2e-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented May 15, 2025

@sebsoto: Overrode contexts on behalf of sebsoto: Red Hat Konflux

In response to this:

/override "Red Hat Konflux"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mansikulkarni96
Copy link
Member Author

/retest

@jrvaldes
Copy link
Contributor

@mansikulkarni96 you may need to rebase to pick the latest konflux config.

This commit bumps the x/net dependency to v0.33.0
to fix CVE-2024-45338.
Ran: go mod tidy && go mod vendor
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@sebsoto
Copy link
Contributor

sebsoto commented May 27, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 33165cb and 2 for PR HEAD ef6343e in total

Copy link
Contributor

openshift-ci bot commented May 28, 2025

@mansikulkarni96: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gcp-e2e-operator ef6343e link true /test gcp-e2e-operator
ci/prow/images ef6343e link true /test images
ci/prow/aws-e2e-operator ef6343e link true /test aws-e2e-operator
ci/prow/azure-e2e-operator ef6343e link true /test azure-e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants