Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPQE-26586: Remove cucushit cases in vSphere multi-vcenter profile #60176

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

duanwei33
Copy link
Contributor

The CSIMigration is not supported in the vSphere multi-vcenter env, so in-tree cases will fail in CI.
Also it is part of fix for: https://issues.redhat.com/browse/OCPQE-26586.

cc @Phaow @chao007

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 26, 2024

@duanwei33: This pull request references OCPQE-26586 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

The CSIMigration is not supported in the vSphere multi-vcenter env, so in-tree cases will fail in CI.
Also it is part of fix for: https://issues.redhat.com/browse/OCPQE-26586.

cc @Phaow @chao007

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bandrade and kuiwang02 December 26, 2024 07:38
@duanwei33
Copy link
Contributor Author

cc @WenXinWei, I removed the feature gate in 4.19, just FYI.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@duanwei33: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-vsphere-ipi-multi-vcenter-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-vsphere-upi-multi-vcenter-tp-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-vsphere-upi-multi-vcenter-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-vsphere-ipi-multi-vcenter-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-vsphere-ipi-multi-vcenter-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-vsphere-upi-multi-vcenter-tp-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-vsphere-ipi-multi-vcenter-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-vsphere-upi-multi-vcenter-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-vsphere-upi-multi-vcenter-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-vsphere-ipi-multi-vcenter-tp-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-vsphere-upi-multi-vcenter-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-vsphere-ipi-multi-vcenter-tp-f28 N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Phaow
Copy link
Contributor

Phaow commented Jan 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanwei33, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
@duanwei33
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@duanwei33: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 2, 2025
@duanwei33
Copy link
Contributor Author

Hi @liangxia, could you help take a look?

Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

@duanwei33: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 02b4d42 into openshift:master Jan 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants