Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OVN to ovn24.09-24.09.1-10.el9fdp #2390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dceara
Copy link
Contributor

@dceara dceara commented Dec 11, 2024

This picks up the following relevant bug fixes:
https://issues.redhat.com/browse/FDP-906
"ovn-controller: lib/ovsdb-idl.c:3596: assertion row->new_datum != NULL failed in ovsdb_idl_txn_write__()"
6448f5e364 pinctrl: Skip non-local mac bindings in run_buffered_binding().
ea35347320 pinctrl: Skip deleted mac bindings in run_buffered_binding().
33a6ae53f4 pinctrl: Use correct map size in pinctrl_handle_put_fdb().
8eaa7d5991 controller: Fix "use after free" issue in statctrl_run().
8579859f51 mac-cache: Properly handle deletion of SB mac_bindings.

https://issues.redhat.com/browse/FDP-752
"ovn-northd IPAM incorrectly reports duplicate IP when part of excluded_ips"
2a24b03f7f ipam: Do not report error for static assigned IPs.

https://issues.redhat.com/browse/FDP-786
"When an ECMP symmetric route is removed, northd removes all logical flows from SBDB for ECMP"
7b00627433 northd: Respect --ecmp-symmetric-reply for single routes.

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

@dceara
Copy link
Contributor Author

dceara commented Dec 11, 2024

@trozet @tssurya FDP24.H was released and includes an updated 24.09 version. This PR bumps OVN and picks up OCP relevant fixes listed above.

@openshift-ci openshift-ci bot requested review from abhat and trozet December 11, 2024 08:04
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dceara
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dceara
Copy link
Contributor Author

dceara commented Dec 11, 2024

Related upstream bump: ovn-kubernetes/ovn-kubernetes#4887

@dceara dceara force-pushed the bump-ovn24.09-FDP24H branch from 8adf216 to 611f7b2 Compare December 11, 2024 11:04
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024
This picks up the following relevant bug fixes:
https://issues.redhat.com/browse/FDP-906
"ovn-controller: lib/ovsdb-idl.c:3596: assertion row->new_datum != NULL failed in ovsdb_idl_txn_write__()"
  6448f5e364 pinctrl: Skip non-local mac bindings in run_buffered_binding().
  ea35347320 pinctrl: Skip deleted mac bindings in run_buffered_binding().
  33a6ae53f4 pinctrl: Use correct map size in pinctrl_handle_put_fdb().
  8eaa7d5991 controller: Fix "use after free" issue in statctrl_run().
  8579859f51 mac-cache: Properly handle deletion of SB mac_bindings.

https://issues.redhat.com/browse/FDP-752
"ovn-northd IPAM incorrectly reports duplicate IP when part of excluded_ips"
  2a24b03f7f ipam: Do not report error for static assigned IPs.

https://issues.redhat.com/browse/FDP-786
"When an ECMP symmetric route is removed, northd removes all logical flows from SBDB for ECMP"
  7b00627433 northd: Respect --ecmp-symmetric-reply for single routes.

Signed-off-by: Dumitru Ceara <[email protected]>
@dceara dceara force-pushed the bump-ovn24.09-FDP24H branch from 611f7b2 to 5bde0a8 Compare December 11, 2024 11:05
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024
@zshi-redhat
Copy link
Contributor

/test e2e-aws-ovn-fdp-qe

@zshi-redhat
Copy link
Contributor

looks like there are two failures about egress IP testing

openshift-extended-test:
total: 52
failures: 2
errors: 0
skipped: 2
failingScenarios:
- "[sig-networking] SDN OVN EgressIP Author:huirwang-ConnectedOnly-Medium-47028-[FdpOvnOvs] After remove EgressIP node tag, EgressIP will failover to other availabel egress nodes. [Serial]"
- "[sig-networking] SDN OVN EgressIP Basic Author:huirwang-NonHyperShiftHOST-High-47021-[FdpOvnOvs] lr-policy-list and snat should be updated correctly after remove pods. [Disruptive] [Serial]"
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-12-18T12:06:33Z"}
error: failed to execute wrapped command: exit status 1

@zshi-redhat
Copy link
Contributor

/test e2e-aws-ovn-fdp-qe

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@dceara: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn 5bde0a8 link false /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-single-node-techpreview 5bde0a8 link false /test e2e-aws-ovn-single-node-techpreview
ci/prow/4.18-upgrade-from-stable-4.17-images 5bde0a8 link true /test 4.18-upgrade-from-stable-4.17-images
ci/prow/e2e-aws-ovn-kubevirt 5bde0a8 link false /test e2e-aws-ovn-kubevirt
ci/prow/security 5bde0a8 link false /test security
ci/prow/e2e-metal-ipi-ovn-techpreview 5bde0a8 link false /test e2e-metal-ipi-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift-conformance-techpreview 5bde0a8 link false /test e2e-aws-ovn-hypershift-conformance-techpreview
ci/prow/okd-scos-e2e-aws-ovn 5bde0a8 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade 5bde0a8 link true /test e2e-azure-ovn-upgrade
ci/prow/images 5bde0a8 link true /test images
ci/prow/e2e-aws-ovn-hypershift 5bde0a8 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway-techpreview 5bde0a8 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway-techpreview
ci/prow/e2e-gcp-ovn 5bde0a8 link true /test e2e-gcp-ovn
ci/prow/e2e-azure-ovn-techpreview 5bde0a8 link false /test e2e-azure-ovn-techpreview
ci/prow/4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade 5bde0a8 link true /test 4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6-techpreview 5bde0a8 link false /test e2e-metal-ipi-ovn-ipv6-techpreview
ci/prow/e2e-aws-ovn-fdp-qe 5bde0a8 link false /test e2e-aws-ovn-fdp-qe

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants