Skip to content

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Jun 20, 2025

Change type: Doc update; Update cert-manager doc for OCP cert-manager's supported istio-csr

Doc JIRA: https://issues.redhat.com/browse/OSSM-9322

Fix Version: service-mesh-docs-main and service-mesh-docs-3.1

Doc Preview: https://95032--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-istio-ambient-mode.html

SME Review/QE Review: @MaxBab @longmuir
Peer Review: @skopacz1

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 20, 2025

🤖 Fri Jul 18 12:36:13 - Prow CI generated the docs preview:

https://95032--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-istio-ambient-mode.html

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2025
@shreyasiddhartha
Copy link
Contributor Author

/label service-mesh

@openshift-ci openshift-ci bot added the service-mesh Label for all Service Mesh PRs label Jun 26, 2025
@longmuir
Copy link

Thanks @shreyasiddhartha, this LGTM!

@shreyasiddhartha
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 14, 2025
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 15, 2025
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, otherwise LGTM!

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 15, 2025
@skopacz1 skopacz1 added this to the Continuous Release milestone Jul 15, 2025
@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 16, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 17, 2025
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent overall. A few things to take a look at, and some things to consider.

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 17, 2025
Copy link

openshift-ci bot commented Jul 18, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 18, 2025
@briandooley
Copy link
Contributor

@shreyasiddhartha Can you make sure that all conversations are resolved in this PR before I merge it?

@briandooley briandooley merged commit db25871 into openshift:service-mesh-docs-main Jul 21, 2025
2 checks passed
@briandooley
Copy link
Contributor

/cherrypick service-mesh-docs-3.1

@openshift-cherrypick-robot

@briandooley: new pull request created: #96351

In response to this:

/cherrypick service-mesh-docs-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shreyasiddhartha
Copy link
Contributor Author

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants