-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSM-9322 Istio ambient mode getting started docs #95032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-9322 Istio ambient mode getting started docs #95032
Conversation
🤖 Fri Jul 18 12:36:13 - Prow CI generated the docs preview: |
/label service-mesh |
e4bcc1f
to
0df39b5
Compare
modules/ossm-deploying-bookinfo-application-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-deploying-bookinfo-application-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-deploying-bookinfo-application-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-deploying-bookinfo-application-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-deploying-bookinfo-application-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-deploying-bookinfo-application-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-deploying-bookinfo-application-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-deploying-bookinfo-application-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
Thanks @shreyasiddhartha, this LGTM! |
/label peer-review-needed |
446c05b
to
2ffebce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, otherwise LGTM!
modules/ossm-scoping-sm-discovery-selectors-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-scoping-sm-discovery-selectors-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
618d4f3
to
afdc9aa
Compare
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent overall. A few things to take a look at, and some things to consider.
/remove-label merge-review-in-progress
/remove-label merge-review-needed
modules/ossm-scoping-sm-discovery-selectors-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-scoping-sm-discovery-selectors-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-deploying-bookinfo-application-istio-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
28c673b
to
7dd688f
Compare
7dd688f
to
5750403
Compare
@shreyasiddhartha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
@shreyasiddhartha Can you make sure that all conversations are resolved in this PR before I merge it? |
db25871
into
openshift:service-mesh-docs-main
/cherrypick service-mesh-docs-3.1 |
@briandooley: new pull request created: #96351 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/remove-label merge-review-needed |
Change type: Doc update; Update cert-manager doc for OCP cert-manager's supported istio-csr
Doc JIRA: https://issues.redhat.com/browse/OSSM-9322
Fix Version: service-mesh-docs-main and service-mesh-docs-3.1
Doc Preview: https://95032--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-istio-ambient-mode.html
SME Review/QE Review: @MaxBab @longmuir
Peer Review: @skopacz1