Skip to content

HCIDOCS-745: Indent bullets on postinstallation configuration.#95004

Merged
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
johnwilkins:HCIDOCS-745
Jun 23, 2025
Merged

HCIDOCS-745: Indent bullets on postinstallation configuration.#95004
ShaunaDiaz merged 1 commit intoopenshift:mainfrom
johnwilkins:HCIDOCS-745

Conversation

@johnwilkins
Copy link
Copy Markdown
Contributor

@johnwilkins johnwilkins commented Jun 19, 2025 •
edited
Loading

Indented bullets properly. Incorporated vale comments. Edits only. No QE needed.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: https://95004--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 19, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2025 •
edited by openshift-ci Bot
Loading

@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Indented bullets properly. Incorporated vale comments.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: http://jowilkin.com:8080/HCIDOCS-745/welcome/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2025 •
edited by openshift-ci Bot
Loading

@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Indented bullets properly. Incorporated vale comments.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: http://jowilkin.com:8080/HCIDOCS-745/welcome/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 19, 2025
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Jun 19, 2025 •
edited
Loading

🤖 Fri Jun 20 19:56:51 - Prow CI generated the docs preview:

https://95004--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/index.html

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2025 •
edited by openshift-ci Bot
Loading

@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Indented bullets properly. Incorporated vale comments.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: https://95004--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2025 •
edited by openshift-ci Bot
Loading

@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Indented bullets properly. Incorporated vale comments. Edits only. No QE needed.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: https://95004--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@johnwilkins
Copy link
Copy Markdown
Contributor Author

johnwilkins commented Jun 19, 2025

/label peer-review-needed

@openshift-ci openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 19, 2025
@eromanova97
Copy link
Copy Markdown
Contributor

eromanova97 commented Jun 20, 2025

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci Bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 20, 2025
eromanova97
eromanova97 reviewed Jun 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have added just one small suggestion outside of scope to consider.
Thank you!

/remove-label peer-review-in-progress

/label peer-review-done

Comment thread post_installation_configuration/index.adoc Outdated
@openshift-ci openshift-ci Bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 20, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 20, 2025

@johnwilkins: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@johnwilkins
Copy link
Copy Markdown
Contributor Author

johnwilkins commented Jun 20, 2025

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 20, 2025
@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 23, 2025
ShaunaDiaz
ShaunaDiaz reviewed Jun 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ShaunaDiaz ShaunaDiaz merged commit 134eb4b into openshift:main Jun 23, 2025
2 checks passed
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
@ShaunaDiaz
Copy link
Copy Markdown
Contributor

ShaunaDiaz commented Jun 23, 2025

/cherrypick enterprise-4.20

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

ShaunaDiaz commented Jun 23, 2025

/cherrypick enterprise-4.19

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

ShaunaDiaz commented Jun 23, 2025

/cherrypick enterprise-4.18

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

ShaunaDiaz commented Jun 23, 2025

/cherrypick enterprise-4.17

@ShaunaDiaz
Copy link
Copy Markdown
Contributor

ShaunaDiaz commented Jun 23, 2025

/cherrypick enterprise-4.16

@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Jun 23, 2025
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 23, 2025

@ShaunaDiaz: new pull request created: #95093

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 23, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 23, 2025

@ShaunaDiaz: new pull request created: #95094

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 23, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 23, 2025

@ShaunaDiaz: new pull request created: #95095

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 23, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 23, 2025

@ShaunaDiaz: new pull request created: #95096

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 23, 2025
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 23, 2025

@ShaunaDiaz: new pull request created: #95097

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eromanova97 eromanova97 eromanova97 left review comments

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

Assignees

@ShaunaDiaz ShaunaDiaz

Labels

branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@johnwilkins @openshift-ci-robot @ocpdocs-previewbot @eromanova97 @ShaunaDiaz @openshift-cherrypick-robot