-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OADP-6290: Created seperate modules from the OADP API assembly [mod-docs work] #94973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OADP-6290: Created seperate modules from the OADP API assembly [mod-docs work] #94973
Conversation
@apurvabhide17: This pull request references OADP-6290 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label OADP |
@apurvabhide17: This pull request references OADP-6290 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@apurvabhide17: This pull request references OADP-6290 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - apart from the xrefs
in modules, which is throwing errors in the Vale bot
not sure what the best solution is.
please can you have a think about it and talk to the team
thanks
da8c29a
to
1a121a8
Compare
/label peer-review-needed |
Hi @apurvabhide17 . Please squash the 2 commits into 1 commit. |
1a121a8
to
4fcf87c
Compare
Hi @dfitzmau, done, I've squashed the commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I added comments inline. I think the VeleroConfig type file needs an include?
backup_and_restore/application_backup_and_restore/oadp-api.adoc
Outdated
Show resolved
Hide resolved
backup_and_restore/application_backup_and_restore/oadp-api.adoc
Outdated
Show resolved
Hide resolved
backup_and_restore/application_backup_and_restore/oadp-api.adoc
Outdated
Show resolved
Hide resolved
916f7d3
to
fbeb2fc
Compare
Fixing xref issue
fbeb2fc
to
2397f6e
Compare
@dfitzmau, ack, thanks. I've implemented your suggestions. |
/label merge-review-needed |
@apurvabhide17: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
OCP 4.20
Issue:
OADP-6290
Link to docs preview: https://94973--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-api.html
QE review:
Note -