Skip to content

OADP-6290: Created seperate modules from the OADP API assembly [mod-docs work] #94973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apurvabhide17
Copy link
Contributor

@apurvabhide17 apurvabhide17 commented Jun 18, 2025

Version(s):
OCP 4.20

Issue:
OADP-6290

Link to docs preview: https://94973--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-api.html

QE review:

  • QE has approved this change.

Note -

  • Modularization work for the oadp-api assembly. Instead of having multiple tables in the assembly, I've moved the content to new modules. Otherwise, there are no technical changes.
  • As discussed with Kathryn, skipping the QE review because this PR focuses on changing structure and there are no technical changes.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 18, 2025

@apurvabhide17: This pull request references OADP-6290 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.19

Note - Modularization work for the oadp-api assembly (no technical changes)

Issue:
OADP-6290

Link to docs preview:

QE review:
Note - As discussed with Kathryn, skipping the QE review because this PR focuses on changing structure and there are no technical changes.
Instead of having multiple tables in the assembly, I've moved the content to new modules. Otherwise, there are no technical changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 18, 2025
@apurvabhide17
Copy link
Contributor Author

/label OADP

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Jun 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 18, 2025

@apurvabhide17: This pull request references OADP-6290 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.20

Issue:
OADP-6290

Link to docs preview:

QE review:

  • QE has approved this change.

Note -

  • Modularization work for the oadp-api assembly. Instead of having multiple tables in the assembly, I've moved the content to new modules. Otherwise, there are no technical changes.
  • As discussed with Kathryn, skipping the QE review because this PR focuses on changing structure and there are no technical changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 18, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 18, 2025

@apurvabhide17: This pull request references OADP-6290 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.20

Issue:
OADP-6290

Link to docs preview: https://94973--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-api.html

QE review:

  • QE has approved this change.

Note -

  • Modularization work for the oadp-api assembly. Instead of having multiple tables in the assembly, I've moved the content to new modules. Otherwise, there are no technical changes.
  • As discussed with Kathryn, skipping the QE review because this PR focuses on changing structure and there are no technical changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@anarnold97 anarnold97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - apart from the xrefs in modules, which is throwing errors in the Vale bot

not sure what the best solution is.

please can you have a think about it and talk to the team

thanks

@apurvabhide17 apurvabhide17 force-pushed the OADP-6290-mod-work-for-OADP-API branch from da8c29a to 1a121a8 Compare June 19, 2025 08:06
@apurvabhide17
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 19, 2025
@dfitzmau dfitzmau added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.20 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 19, 2025
@dfitzmau
Copy link
Contributor

Hi @apurvabhide17 . Please squash the 2 commits into 1 commit.

@apurvabhide17 apurvabhide17 force-pushed the OADP-6290-mod-work-for-OADP-API branch from 1a121a8 to 4fcf87c Compare June 19, 2025 14:30
@apurvabhide17
Copy link
Contributor Author

Hi @dfitzmau, done, I've squashed the commits.

Copy link
Contributor

@dfitzmau dfitzmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I added comments inline. I think the VeleroConfig type file needs an include?

@dfitzmau dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 19, 2025
@apurvabhide17 apurvabhide17 force-pushed the OADP-6290-mod-work-for-OADP-API branch 2 times, most recently from 916f7d3 to fbeb2fc Compare June 19, 2025 15:50
@apurvabhide17 apurvabhide17 force-pushed the OADP-6290-mod-work-for-OADP-API branch from fbeb2fc to 2397f6e Compare June 19, 2025 17:26
@apurvabhide17
Copy link
Contributor Author

Nice work. I added comments inline. I think the VeleroConfig type file needs an include?

@dfitzmau, ack, thanks. I've implemented your suggestions.
Now, adding merge-review label.

@apurvabhide17
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 19, 2025
Copy link

openshift-ci bot commented Jun 19, 2025

@apurvabhide17: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-needed Signifies that the merge review team needs to review this PR OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants