-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add updates to 4.18 release notes #94940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enterprise-4.18
Are you sure you want to change the base?
Add updates to 4.18 release notes #94940
Conversation
🤖 Thu Jun 19 12:42:16 - Prow CI generated the docs preview: |
/label peer-review-needed |
@@ -6,6 +6,9 @@ include::_attributes/common-attributes.adoc[] | |||
|
|||
toc::[] | |||
|
|||
[role="_abstract"] | |||
The release notes summarize the new features and enhancements, notable technical changes, and known bugs with this release of OpenShift Virtualization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release notes summarize the new features and enhancements, notable technical changes, and known bugs with this release of OpenShift Virtualization. | |
The release notes summarize new features and enhancements, notable technical changes, and known issues for this release of OpenShift Virtualization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a "Known issues" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I have to write a short description for OpenShift Virtualization release notes, hence I've added it under this section.
@@ -129,11 +132,13 @@ These sections include streamlined and improved content. | |||
== Deprecated and removed features | |||
//NOTE: Comment out deprecated and removed features (and their IDs) if not used in a release | |||
|
|||
[role="_abstract"] | |||
The deprecated and removed features section lists the features that are no longer supported or planned for removal in this release of OpenShift Virtualization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think deprecated means that support is still available. For example, 4.19 RN doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a statement similar to the 4.19 RN doc's statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dfitzmau – As per the requirements outlined in the Jira issue, I've added the brief description mentioned in the issue details. Please let me know if you'd still prefer me to include a statement similar to the one used for 4.19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @Vaishali-gif-rh. I don't think I can make these calls for CNV, but I wanted to call out that unclear support statements might insight some undesired customer feedback. I see that you meet the DITA expectation that is outlined on the Jira.
0b59388
to
3566bd9
Compare
@Vaishali-gif-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
4.18+
Issue:
https://issues.redhat.com/browse/CNV-58674
Link to docs preview:
https://94940--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-18-release-notes.html
QE review:
No QE required
Additional information:
Added the short description that appears immediately after the title.