Skip to content

NO-JIRA: Clarifies CSRF protection note for Basic auth challenges #94939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions modules/oauth-token-requests.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,10 @@ login flow.

[NOTE]
====
To prevent cross-site request forgery (CSRF) attacks against browser
clients, only send Basic authentication challenges with if a
`X-CSRF-Token` header is on the request. Clients that expect
to receive Basic `WWW-Authenticate` challenges must set this header to a
non-empty value.
To prevent cross-site request forgery (CSRF) attacks against browser clients,
only send Basic authentication challenges if the request includes a
`X-CSRF-Token` header. Clients that expect to receive Basic `WWW-Authenticate`
challenges must set this header to a non-empty value.

If the authenticating proxy cannot support `WWW-Authenticate` challenges,
or if {product-title} is configured to use an identity provider that does
Expand Down