OSDOCS-14341-attributes: Fixed unrendered IBM attributes #94841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/S
dfitzmau
force-pushed
the
OSDOCS-14341-attributes
branch
4 times, most recently
from
4aad640 to
69795da
Compare
|
🤖 Thu Jun 19 08:33:23 - Prow CI generated the docs preview: |
dfitzmau
force-pushed
the
OSDOCS-14341-attributes
branch
from
69795da to
8c7172a
Compare
openshift-ci
bot
added
size/M
dfitzmau
force-pushed
the
OSDOCS-14341-attributes
branch
4 times, most recently
from
bf69552 to
0c6e426
Compare
dfitzmau
added
the
peer-review-needed
mburke5678
added
the
peer-review-in-progress
|
@dfitzmau LGTM. I examined a number of the IBM install files and searched for unrendered attributes, |
mburke5678
added
peer-review-done
dfitzmau
force-pushed
the
OSDOCS-14341-attributes
branch
from
0c6e426 to
c157e3b
Compare
dfitzmau
force-pushed
the
OSDOCS-14341-attributes
branch
from
c157e3b to
d74b057
Compare
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried various ways to get the IBM attributes to render in headings but no matter where I relocate the attributes include or the guidance from our doc, these changes do not work. Best to try hard-coding to avoid the unrendered attributes on docs.redhat.com.
I'm trialing the changes on the 4.13 branch as the ultimate test is publication on docs.redhat.com.
Version(s):
4.13
Issue:
OSDOCS-14341
Preview: