Skip to content

OLS-1756: Subscription services for OLS #94827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: lightspeed-docs-main
Choose a base branch
from
Open

OLS-1756: Subscription services for OLS #94827

wants to merge 1 commit into from
+20 −0

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Jun 16, 2025 •
edited
Loading

Affects:
lightspeed-main
lightspeed-docs-1.0

PR must be CP'd back to the lightspeed-docs-1.0 branch.

Version(s): 1.0

Issue: https://issues.redhat.com/browse/OLS-1756

Link to docs preview:
https://94827--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/install/ols-installing-openshift-lightspeed.html#about-subscription-requirements_ols-installing-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 16, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-1756 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 16, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-1756 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0

PR must be CP'd back to the lightspeed-docs-1.0 branch.

Version(s): 1.0

Issue: https://issues.redhat.com/browse/OLS-1756

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 16, 2025 •
edited
Loading

🤖 Wed Jun 18 14:23:36 - Prow CI generated the docs preview:

https://94827--ocpdocs-pr.netlify.app/
https://94827--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/about/ols-about-openshift-lightspeed.html
https://94827--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/olsconfigure-api.html
https://94827--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html
https://94827--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/install/ols-installing-openshift-lightspeed.html
https://94827--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/operate/ols-using-openshift-lightspeed.html
https://94827--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/release_notes/ols-release-notes.html
https://94827--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/troubleshoot/ols-troubleshooting-openshift-lightspeed.html

@rh-tokeefe
Copy link
Contributor Author

/retest

1 similar comment
@rh-tokeefe
Copy link
Contributor Author

/retest

@rh-tokeefe
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-1756 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0

PR must be CP'd back to the lightspeed-docs-1.0 branch.

Version(s): 1.0

Issue: https://issues.redhat.com/browse/OLS-1756

Link to docs preview:
https://94827--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/install/ols-installing-openshift-lightspeed.html#about-subscription-requirements_ols-installing-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gauravsingh85
Copy link

LGTM

1 similar comment
@JoaoFula
Copy link
Contributor

LGTM

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 18, 2025
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 18, 2025
@lpettyjo lpettyjo self-requested a review June 18, 2025 13:25
lpettyjo
lpettyjo reviewed Jun 18, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have three commits. For lightspeed, do you squash to one commit? If so, see the OpenShift Docs Manual for the procedure for doing this: https://docs.google.com/document/d/1fLMpK4bqthtFlCwA36yeo2cI-pExFpX76VMnSi_In6Q/edit?tab=t.0#heading=h.epes4xf06pzk. If you have any questions, just let me know.

Otherwise, LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 18, 2025
@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 18, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 18, 2025

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpettyjo lpettyjo lpettyjo left review comments

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rh-tokeefe @openshift-ci-robot @ocpdocs-previewbot @gauravsingh85 @JoaoFula @lpettyjo