-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-14942: corrections to ingress controller docs MicroShift #94817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The This is because your PR targets the If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
e6638f3
to
33e99a5
Compare
@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5b75ec7
to
76c641e
Compare
@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ShaunaDiaz Added a few suggestion. Good work here. This stuff seems tricky to document. |
2030fa6
to
fd7124d
Compare
@ShaunaDiaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.20 |
@ShaunaDiaz: new pull request created: #95090 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: new pull request created: #95091 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.19, 4.20+
Issue:
OSDOCS-14942
Link to docs preview:
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-ingress-controller.html
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-using-config-yaml.html
QE review: