Skip to content

OSDOCS-14942: corrections to ingress controller docs MicroShift #94817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Jun 16, 2025

Version(s):
4.19, 4.20+

Issue:
OSDOCS-14942

Link to docs preview:
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-ingress-controller.html
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-using-config-yaml.html

QE review:

  • N/A no technical information changed; updates formatting, changes the filename and ID of module (does not update procedure steps).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 16, 2025

@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-14942

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2025
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Jun 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 16, 2025

@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue.

In response to this:

Version(s):
4.19, 4.20+

Issue:
OSDOCS-14942

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz changed the title OSDOCS-14942: corrections to ingress controller docs MicroShift [WIP]OSDOCS-14942: corrections to ingress controller docs MicroShift Jun 16, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 16, 2025

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2025
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-14942 branch 2 times, most recently from e6638f3 to 33e99a5 Compare June 16, 2025 19:30
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 16, 2025

@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue.

In response to this:

Version(s):
4.19, 4.20+

Issue:
OSDOCS-14942

Link to docs preview:
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-ingress-controller.html
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-using-config-yaml.html

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-14942 branch 4 times, most recently from 5b75ec7 to 76c641e Compare June 17, 2025 17:06
@ShaunaDiaz ShaunaDiaz changed the title [WIP]OSDOCS-14942: corrections to ingress controller docs MicroShift OSDOCS-14942: corrections to ingress controller docs MicroShift Jun 17, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2025

@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue.

In response to this:

Version(s):
4.19, 4.20+

Issue:
OSDOCS-14942

Link to docs preview:
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-ingress-controller.html
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-using-config-yaml.html

QE review:

  • N/A no technical information changed; updates formatting.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2025

@ShaunaDiaz: This pull request references OSDOCS-14942 which is a valid jira issue.

In response to this:

Version(s):
4.19, 4.20+

Issue:
OSDOCS-14942

Link to docs preview:
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-ingress-controller.html
https://94817--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-using-config-yaml.html

QE review:

  • N/A no technical information changed; updates formatting, changes the filename and ID of module (does not update procedure steps).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 18, 2025
@mburke5678
Copy link
Contributor

@ShaunaDiaz Added a few suggestion. Good work here. This stuff seems tricky to document.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 19, 2025
@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-14942 branch 2 times, most recently from 2030fa6 to fd7124d Compare June 23, 2025 12:43
Copy link

openshift-ci bot commented Jun 23, 2025

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit 58c7b7a into openshift:main Jun 23, 2025
2 checks passed
@ShaunaDiaz
Copy link
Contributor Author

/cherrypick enterprise-4.19

@ShaunaDiaz
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #95090

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #95091

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants