Skip to content

OBSDOCS-1997: Add a redirect to logging docs and remove them #94807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OBSDOCS-1997: Add a redirect to logging docs and remove them #94807

wants to merge 1 commit into from

Conversation

theashiot
Copy link
Contributor

@theashiot theashiot commented Jun 15, 2025 •
edited
Loading

Version(s): 4.20

Issue: https://issues.redhat.com/browse/OBSDOCS-1997

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 15, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-1997 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19

Issue:

Link to docs preview: https://issues.redhat.com/browse/OBSDOCS-1997

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2025
@theashiot
Copy link
Contributor Author

/test all

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 15, 2025 •
edited
Loading

🤖 Mon Jun 16 19:43:00 - Prow CI generated the docs preview:

https://94807--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/about-logging.html

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2025
@theashiot theashiot marked this pull request as ready for review June 16, 2025 15:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2025
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 16, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-1997 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.19

Issue: https://issues.redhat.com/browse/OBSDOCS-1997

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 16, 2025

@theashiot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-1997 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s): 4.20

Issue: https://issues.redhat.com/browse/OBSDOCS-1997

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theashiot
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 17, 2025
@theashiot
Copy link
Contributor Author

/remove-label merge-review-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 17, 2025

@theashiot: The label(s) /remove-label merge-review-required cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, stability-fix-approved, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label merge-review-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@theashiot
Copy link
Contributor Author

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 17, 2025
@theashiot
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 17, 2025
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 17, 2025
mburke5678
mburke5678 reviewed Jun 17, 2025
View reviewed changes
observability/logging/about-logging.adoc

[NOTE]
====
Because {logging} releases on a different cadence from {product-title}, the {logging} documentation is available as a separate documentation set at link:https://docs.redhat.com/en/documentation/red_hat_openshift_logging/[Red{nbsp}Hat OpenShift {logging-uc}].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this link work?

@mburke5678
Copy link
Contributor

@theashiot Just one question. Otherwise LGTM.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.20 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 17, 2025
@mburke5678 mburke5678 added this to the Planned for 4.20 GA milestone Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@KarieCook KarieCook KarieCook approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.20 GA
Development

Successfully merging this pull request may close these issues.
5 participants
@theashiot @openshift-ci-robot @ocpdocs-previewbot @mburke5678 @KarieCook