Skip to content

[ROX-29262] Update docs for Scanner V4 installed by default #94296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Jun 4, 2025

Version(s):
4.8

Issue

Links to docs previews:

QE review: ACS has no QE, approved by SMEs

  • QE has approved this change.

Additional information:
Note to reviewers: Almost all content has been approved by SMEs with a few exceptions but as GA is next Monday, I am sending this to peer review with those few outstanding items remaining.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 4, 2025

🤖 Tue Jun 24 19:10:29 - Prow CI generated the docs preview:
https://94296--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch 2 times, most recently from 4d45111 to 898084b Compare June 4, 2025 21:54
@kcarmichael08 kcarmichael08 added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.8 labels Jun 4, 2025
@kcarmichael08 kcarmichael08 added this to the Continuous Release milestone Jun 4, 2025
@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch from 898084b to 4b1697c Compare June 11, 2025 16:15
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2025
@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch from 4b1697c to 775b946 Compare June 16, 2025 14:11
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2025
@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch 2 times, most recently from 8080208 to 001040c Compare June 16, 2025 14:58
@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch 3 times, most recently from 80b8cec to 6d221d7 Compare June 16, 2025 18:52
@kcarmichael08 kcarmichael08 added peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 16, 2025
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 17, 2025
@kcarmichael08
Copy link
Contributor Author

Hi @RTann and @mburke5678 , this already went into peer review since the doc freeze was yesterday, so comments that were made after the peer review started won't be addressed until after the peer review is over. I'm trying not to overload Michael since he started the review already, and it's a large PR. Thanks for your understanding.

@mburke5678
Copy link
Contributor

@kcarmichael08 I added some comments. I am having trouble with the previews as your links are assembly level and most of the changes are module level. If you can update the preview links to the actual modules where the changes are, that would be extremely helpful. I can look later if you do, or allow the merge reviewer to look at the previews?

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 17, 2025
@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch from 6d221d7 to b50f0e1 Compare June 18, 2025 20:25
@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch from b50f0e1 to 84b58d4 Compare June 18, 2025 22:07
@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch 2 times, most recently from 84435b9 to 0c6c6ea Compare June 24, 2025 14:32
Copy link

@mclasmeier mclasmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Kerry.

Note, my review is limited to install related aspects.

@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch from 0c6c6ea to 9d29af8 Compare June 24, 2025 15:43
Copy link

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some final comments. probably no need for another review

@kcarmichael08 kcarmichael08 force-pushed the ROX-29262-scannerv4-default branch from 9d29af8 to 77f12c6 Compare June 24, 2025 19:00
Copy link

openshift-ci bot commented Jun 24, 2025

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit 6eb1a9e into openshift:rhacs-docs-main Jun 24, 2025
2 checks passed
@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.8

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #95182

In response to this:

/cherrypick rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.8 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants