-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[ROX-29262] Update docs for Scanner V4 installed by default #94296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROX-29262] Update docs for Scanner V4 installed by default #94296
Conversation
🤖 Tue Jun 24 19:10:29 - Prow CI generated the docs preview: |
4d45111
to
898084b
Compare
898084b
to
4b1697c
Compare
4b1697c
to
775b946
Compare
8080208
to
001040c
Compare
80b8cec
to
6d221d7
Compare
Hi @RTann and @mburke5678 , this already went into peer review since the doc freeze was yesterday, so comments that were made after the peer review started won't be addressed until after the peer review is over. I'm trying not to overload Michael since he started the review already, and it's a large PR. Thanks for your understanding. |
@kcarmichael08 I added some comments. I am having trouble with the previews as your links are assembly level and most of the changes are module level. If you can update the preview links to the actual modules where the changes are, that would be extremely helpful. I can look later if you do, or allow the merge reviewer to look at the previews? |
6d221d7
to
b50f0e1
Compare
modules/vulnerability-management-more-views-all-vuln-images.adoc
Outdated
Show resolved
Hide resolved
b50f0e1
to
84b58d4
Compare
84435b9
to
0c6c6ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Kerry.
Note, my review is limited to install related aspects.
0c6c6ea
to
9d29af8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some final comments. probably no need for another review
9d29af8
to
77f12c6
Compare
@kcarmichael08: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick rhacs-docs-4.8 |
@kcarmichael08: new pull request created: #95182 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.8
Issue
Links to docs previews:
QE review: ACS has no QE, approved by SMEs
Additional information:
Note to reviewers: Almost all content has been approved by SMEs with a few exceptions but as GA is next Monday, I am sending this to peer review with those few outstanding items remaining.