Skip to content

OCPBUGS-56989: Swapped out v4InternalSubnet for internalJoinSubnet #94168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: enterprise-4.16
Choose a base branch
from
Open

OCPBUGS-56989: Swapped out v4InternalSubnet for internalJoinSubnet #94168

wants to merge 1 commit into from

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jun 3, 2025 •
edited
Loading

Version(s):
4.15 and 4.16

Issue:
OCPBUGS-56989

Link to docs preview:

  • SME has approved this change (Ryan Howe).
  • QE has approved this change (Arnab Gosh).

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 3, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-56989, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-56989 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.16

Issue:
OCPBUGS-56989

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau added branch/enterprise-4.16 and removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 3, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 3, 2025 •
edited
Loading

🤖 Fri Jun 06 10:00:29 - Prow CI generated the docs preview:

https://94168--ocpdocs-pr.netlify.app/
https://94168--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ovn_kubernetes_network_provider/migrate-from-openshift-sdn.html

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 3, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-56989, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-56989 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.16

Issue:
OCPBUGS-56989

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arghosh93
arghosh93 suggested changes Jun 5, 2025
View reviewed changes
modules/nw-ovn-kubernetes-migration.adoc Outdated
@@ -190,7 +190,7 @@ $ oc patch Network.operator.openshift.io cluster --type=merge \
"ovnKubernetesConfig": {
"mtu": <mtu>,
"genevePort": <port>,
"v4InternalSubnet": "<ipv4_subnet>",
"InternalJoinSubnet": "ipv4_subnet",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be

"ovnKubernetesConfig": {
        "mtu": <mtu>,
        "genevePort": <port>,
         "ipv4":
            "InternalJoinSubnet": "ipv4_subnet",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @arghosh93 . Updated.

arghosh93
arghosh93 reviewed Jun 6, 2025
View reviewed changes
modules/nw-ovn-kubernetes-migration.adoc Outdated
@@ -190,7 +190,8 @@ $ oc patch Network.operator.openshift.io cluster --type=merge \
"ovnKubernetesConfig": {
"mtu": <mtu>,
"genevePort": <port>,
"v4InternalSubnet": "<ipv4_subnet>",
"ipv4":
"InternalJoinSubnet": "ipv4_subnet",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we keep 'ipv4_subnet' within <> ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @arghosh93 . My apologies. Updated and included the angle brackets.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 6, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arghosh93
Copy link

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2025
@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 6, 2025
@brendan-daly-red-hat
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 6, 2025
brendan-daly-red-hat
brendan-daly-red-hat reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm onboarding as a peer reviewer, so please wait for @skopacz1 to approve my review before you proceed.

@skopacz1 skopacz1 added this to the Continuous Release milestone Jun 6, 2025
skopacz1
skopacz1 approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brendan's peer review LGTM!

@brendan-daly-red-hat
Copy link
Contributor

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arghosh93 arghosh93 arghosh93 requested changes

@brendan-daly-red-hat brendan-daly-red-hat brendan-daly-red-hat left review comments

@skopacz1 skopacz1 skopacz1 approved these changes

Assignees

@arghosh93 arghosh93

Labels
branch/enterprise-4.15 branch/enterprise-4.16 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @arghosh93 @brendan-daly-red-hat @skopacz1