-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-14757 greatly reducing GCP sample install config files #93709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ed66965
29986df
3211bf4
1609da9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // * installing/installing_gcp/installing-gcp-customizations.adoc | ||
| // * installing/installing_gcp/installing-gcp-network-customizations.adoc | ||
| // * installing/installing_gcp/installing-gcp-vpc.adoc | ||
| // * installing/installing_gcp/installing-gcp-private.adoc | ||
| // * installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="installation-gcp-config-yaml_{context}"] | ||
| = Sample customized install-config.yaml file for {gcp-full} | ||
|
|
||
| [role="_abstract"] | ||
| To specify more details about your {product-title} cluster's platform or modify the values of the required parameters, you can customize the `install-config.yaml` file. | ||
|
|
||
| [IMPORTANT] | ||
| ==== | ||
| This sample YAML file is provided for reference only. You must obtain your `install-config.yaml` file by using the installation program and modify it. | ||
| ==== | ||
|
|
||
| [source,yaml] | ||
| ---- | ||
| apiVersion: v1 | ||
| baseDomain: example.com | ||
| pullSecret: '{"auths": ...}' | ||
| controlPlane: | ||
| name: master | ||
| replicas: 3 | ||
| platform: | ||
| gcp: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure how minimal you want to go but this
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, I am open to suggestions. At a minimum I'd like to put 1 parameter in each section. is there another you would recommend? |
||
| type: n2-standard-4 | ||
| compute: | ||
| - name: worker | ||
| replicas: 3 | ||
| platform: | ||
| gcp: | ||
| type: n2-standard-4 | ||
| metadata: | ||
| name: test-cluster | ||
| networking: | ||
| clusterNetwork: | ||
| - cidr: 10.128.0.0/14 | ||
| hostPrefix: 23 | ||
| platform: | ||
| gcp: | ||
| projectID: sample-project | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bscott-rh Besides, I'm trying to understand the updates, for example, in the 4.18 doc chapter "Chapter 6. Installing a cluster on GCP in a disconnected environment", the section "6.5. Creating the installation configuration file" explains how to edit "install-config.yaml" to give the additional information that is required for an installation in a restricted network. But in your changes, it seems no such info, how do you expect the end-users know generally what's required?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @jianli-wei , I am resuming work on this ticket finally :) I will add the region parameter. Regarding the updates, if the correct information is in the "Creating the installation configuration file" procedure, then it is okay for it to be removed from the sample install-config.yaml file, because the sample file is only meant to be a reference for the syntax of the file, not a complete config file. Does that make sense? |
||
| region: us-east1 | ||
| ---- | ||
| where: | ||
|
|
||
| `controlPlane`:: Specifies parameters that apply to control plane machines. | ||
| `compute`:: Specifies parameters that apply to compute machines. | ||
| `networking`:: Specifies parameters that apply to the cluster networking configuration. If you do not provide networking values, the installation program provides default values. | ||
| `platform`:: Specifies parameters that apply to the infrastructure platform that hosts the cluster. | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,8 @@ | |
| [id="private-clusters-about-gcp_{context}"] | ||
| = Private clusters in {gcp-short} | ||
|
|
||
| To create a private cluster on {gcp-first}, you must provide an existing private VPC and subnets to host the cluster. The installation program must also be able to resolve the DNS records that the cluster requires. The installation program configures the Ingress Operator and API server for only internal traffic. | ||
| [role="_abstract"] | ||
| To create a private cluster on {gcp-first}, you must provide an existing private VPC and subnets to host the cluster, and you must specify `publish: Internal` in your `install-config.yaml` file. The installation program must also be able to resolve the DNS records that the cluster requires. The installation program configures the Ingress Operator and API server for only internal traffic. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggest to replace "you must provide an existing private VPC and subnets to host the cluster" with "you must provide an existing VPC network and subnets to host the cluster", i.e. remove the word "private" and add the word "network". |
||
|
|
||
| The cluster still requires access to internet to access the {gcp-short} APIs. | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.