-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-31697: Added user-managed LB note to nw-configuring-route-tim… #93206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@dfitzmau: This pull request references Jira Issue OCPBUGS-31697, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the route timeout documentation to include an IMPORTANT note for users who configure a user-managed load balancer. The changes include a new note block to warn about configuring the load balancer’s timeout values, as well as minor formatting improvements.
- Added an IMPORTANT note advising that the load balancer’s timeout must exceed the route service’s timeout to prevent congestion.
- Improved overall text formatting for clarity.
Just one comment, the rest looks good. Thanks |
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The This is because your PR targets the If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
Version(s):
4.12+
Issue:
OCPBUGS-31697
Link to docs preview:
Add. resources: