Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-1809: adding release notes for AWS Load Balancer Operator v1.2 #86682

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2025

@ahardin-rh: This pull request references NE-1809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
https://issues.redhat.com//browse/NE-1809

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 3, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2025

@ahardin-rh: This pull request references NE-1809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.16+

Issue:
https://issues.redhat.com//browse/NE-1809

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2025

@ahardin-rh: This pull request references NE-1809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.16+

Issue:
https://issues.redhat.com//browse/NE-1809

Preview Build:
https://86682--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/aws_load_balancer_operator/aws-load-balancer-operator-release-notes.html

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ahardin-rh ahardin-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 3, 2025
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 3, 2025
@@ -23,10 +23,17 @@ For an overview of the AWS Load Balancer Operator, see xref:../../../networking/
AWS Load Balancer Operator currently does not support AWS GovCloud.
====

[id="aws-load-balancer-operator-release-notes-1.2"]
== AWS Load Balancer Operator 1.2.0

Copy link
Contributor

@alebedev87 alebedev87 Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why https://issues.redhat.com/browse/CFE-1133 was private and hence not added to the advisory. But I think that we should mention the fact that the platform tags (ones defined in Infrastructure resource) will be added to all AWS objects created by the controller now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chiragkyal : is there a reason not to mention this in the release notes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chiragkyal : is there a reason not to mention this in the release notes?

I don't see any strong reason for not mentioning the feature information in the release notes.

I don't know why https://issues.redhat.com/browse/CFE-1133 was private and hence not added to the advisory.

@TrilokGeer, do you happen to know why we kept the story private? Should we change the restriction?

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2025
Copy link

openshift-ci bot commented Jan 6, 2025

@ahardin-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alebedev87
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@ahardin-rh: This pull request references NE-1809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.16+

Issue:
https://issues.redhat.com//browse/NE-1809
https://issues.redhat.com/browse/OSDOCS-12483

Preview Build:
https://86682--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/aws_load_balancer_operator/aws-load-balancer-operator-release-notes.html

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShudiLi
Copy link
Member

ShudiLi commented Jan 8, 2025

/lgtm
thanks

@ahardin-rh ahardin-rh merged commit 48181d8 into openshift:main Jan 8, 2025
2 checks passed
@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #86807

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-4.17

@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #86808

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #86809

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants