-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NE-1809: adding release notes for AWS Load Balancer Operator v1.2 #86682
Conversation
@ahardin-rh: This pull request references NE-1809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Mon Jan 06 19:38:05 - Prow CI generated the docs preview: |
@ahardin-rh: This pull request references NE-1809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ahardin-rh: This pull request references NE-1809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/remove-label peer-review-needed
/label peer-review-done
...etworking_operators/aws_load_balancer_operator/aws-load-balancer-operator-release-notes.adoc
Show resolved
Hide resolved
@@ -23,10 +23,17 @@ For an overview of the AWS Load Balancer Operator, see xref:../../../networking/ | |||
AWS Load Balancer Operator currently does not support AWS GovCloud. | |||
==== | |||
|
|||
[id="aws-load-balancer-operator-release-notes-1.2"] | |||
== AWS Load Balancer Operator 1.2.0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why https://issues.redhat.com/browse/CFE-1133 was private and hence not added to the advisory. But I think that we should mention the fact that the platform tags (ones defined in Infrastructure
resource) will be added to all AWS objects created by the controller now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chiragkyal : is there a reason not to mention this in the release notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @TrilokGeer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chiragkyal : is there a reason not to mention this in the release notes?
I don't see any strong reason for not mentioning the feature information in the release notes.
I don't know why https://issues.redhat.com/browse/CFE-1133 was private and hence not added to the advisory.
@TrilokGeer, do you happen to know why we kept the story private? Should we change the restriction?
@ahardin-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
@ahardin-rh: This pull request references NE-1809 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/cherrypick enterprise-4.16 |
@ahardin-rh: new pull request created: #86807 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick enterprise-4.17 |
/cherrypick enterprise-4.18 |
@ahardin-rh: new pull request created: #86808 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ahardin-rh: new pull request created: #86809 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.16+
Issue:
https://issues.redhat.com//browse/NE-1809
https://issues.redhat.com/browse/OSDOCS-12483
Preview Build:
https://86682--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/aws_load_balancer_operator/aws-load-balancer-operator-release-notes.html
QE review: