Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-46558#adding new region #86645

Merged
merged 1 commit into from
Jan 20, 2025
Merged

OCPBUGS-46558#adding new region #86645

merged 1 commit into from
Jan 20, 2025
+1 −0

Conversation

brendan-daly-red-hat
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat commented Jan 2, 2025 •
edited
Loading

Versions:
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-46558

Link to docs preview:
Supported Azure regions

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 2, 2025
@ocpdocs-previewbot
Copy link

🤖 Thu Jan 02 15:05:05 - Prow CI generated the docs preview:

https://86645--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure/installing-azure-account.html
https://86645--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure/upi/installing-azure-user-infra.html
https://86645--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_azure/upi/installing-restricted-networks-azure-user-provisioned.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 2, 2025

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brendan-daly-red-hat
Copy link
Contributor Author

@jinyunma, PTAL at the draft update.

@jinyunma
Copy link

jinyunma commented Jan 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@brendan-daly-red-hat
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 7, 2025
@cbippley
Copy link
Contributor

cbippley commented Jan 7, 2025

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 7, 2025
cbippley
cbippley reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbippley
Copy link
Contributor

cbippley commented Jan 7, 2025

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 7, 2025
@brendan-daly-red-hat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 20, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 20, 2025
xenolinux
xenolinux reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux merged commit 8a5a171 into openshift:main Jan 20, 2025
2 checks passed
@xenolinux xenolinux added this to the Continuous Release milestone Jan 20, 2025
@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.14

@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.15

@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.16

@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.17

@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 20, 2025
Merged
@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #87244

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #87245

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jan 20, 2025
Merged
Merged
@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #87246

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #87247

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jan 20, 2025
Merged
Merged
@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #87248

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbippley cbippley cbippley left review comments

@xenolinux xenolinux xenolinux left review comments

Assignees

@jinyunma jinyunma

Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@brendan-daly-red-hat @ocpdocs-previewbot @jinyunma @cbippley @xenolinux @openshift-cherrypick-robot