enterprise-4.13 osdocs 12909#106787
Open
jmanthei wants to merge 1 commit intoopenshift:enterprise-4.13from
Open
enterprise-4.13 osdocs 12909#106787jmanthei wants to merge 1 commit intoopenshift:enterprise-4.13from
jmanthei wants to merge 1 commit intoopenshift:enterprise-4.13from
Conversation
openshift-ci
bot
added
the
size/M
|
🤖 Tue Feb 17 18:44:46 - Prow CI generated the docs preview: |
Collaborator
There was a problem hiding this comment.
🤖 [error] OpenShiftAsciiDoc.ModuleContainsContentType: Module is missing the '_mod-docs-content-type' variable.
| and "-". The default is the hashed internal key name for the route. | ||
| |`haproxy.router.openshift.io/pod-concurrent-connections`| Sets the maximum number of connections that are allowed to a backing pod from a router. + | ||
| Note: If there are multiple pods, each can have this many connections. If you have multiple routers, there is no coordination among them, each may connect this many times. If not set, or set to 0, there is no limit. | | ||
| Note: If there are multiple pods, each can have this many connections. If you have multiple routers, there is no coordination among them, each may connect this many times. If not set, or set to 0, there is no limit. |
Collaborator
There was a problem hiding this comment.
🤖 [error] RedHat.Spacing: Keep one space between words in 'connections. If'. For more information, see RedHat.Spacing.
|
@jmanthei: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
jeana-redhat
left a comment
jeana-redhat
left a comment
There was a problem hiding this comment.
Merge conflict resolution notes
| |`haproxy.router.openshift.io/balance`| Sets the load-balancing algorithm. Available options are `random`, `source`, `roundrobin`, and `leastconn`. The default value is `source` for TLS passthrough routes. For all other routes, the default is `random`. |`ROUTER_TCP_BALANCE_SCHEME` for passthrough routes. Otherwise, use `ROUTER_LOAD_BALANCE_ALGORITHM`. | ||
| |`haproxy.router.openshift.io/disable_cookies`| Disables the use of cookies to track related connections. If set to `'true'` or `'TRUE'`, the balance algorithm is used to choose which back-end serves connections for each incoming HTTP request. | | ||
| |Variable | Description | ||
| |`haproxy.router.openshift.io/balance`| Sets the load-balancing algorithm. Available options are `random`, `source`, `roundrobin`[^1^], and `leastconn`. The default value is `source` for TLS passthrough routes. For all other routes, the default is `random`. |
Contributor
There was a problem hiding this comment.
This [^1^] should not be added to this version, looks like that's a new annotation starting in 4.14
Suggested change
| |`haproxy.router.openshift.io/balance`| Sets the load-balancing algorithm. Available options are `random`, `source`, `roundrobin`[^1^], and `leastconn`. The default value is `source` for TLS passthrough routes. For all other routes, the default is `random`. | |
| |`haproxy.router.openshift.io/balance`| Sets the load-balancing algorithm. Available options are `random`, `source`, `roundrobin`, and `leastconn`. The default value is `source` for TLS passthrough routes. For all other routes, the default is `random`. |
| | Sets an allowlist for the route. The allowlist is a space-separated list of IP addresses and CIDR ranges for the approved source addresses. Requests from IP addresses that are not in the allowlist are dropped. | ||
|
|
||
| The maximum number of IP addresses and CIDR ranges directly visible in the `haproxy.config` file is 61. [^1^] | | ||
| The maximum number of IP addresses and CIDR ranges directly visible in the `haproxy.config` file is 61. [^2^] |
Contributor
There was a problem hiding this comment.
Which means this should stay as 1
Suggested change
| The maximum number of IP addresses and CIDR ranges directly visible in the `haproxy.config` file is 61. [^2^] | |
| The maximum number of IP addresses and CIDR ranges directly visible in the `haproxy.config` file is 61. [^1^] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s):
Issue:
Link to docs preview:
QE review:
Additional information: