Skip to content

Conversation

@vanhalenar
Copy link
Contributor

@vanhalenar vanhalenar commented Nov 24, 2025

This test is deploying a NetworkNodePolicy and checking if the VFs are configured correctly.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025

@vanhalenar: This pull request references USHIFT-6141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vanhalenar
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vanhalenar
Copy link
Contributor Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

@vanhalenar: The following commands are available to trigger required jobs:

/test e2e-aws-ai-model-serving
/test e2e-aws-footprint-and-performance
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm
/test e2e-aws-tests-bootc-release
/test e2e-aws-tests-bootc-release-arm
/test e2e-aws-tests-bootc-upstream
/test e2e-aws-tests-bootc-upstream-arm
/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm
/test e2e-aws-tests-periodic
/test e2e-aws-tests-periodic-arm
/test e2e-aws-tests-release
/test e2e-aws-tests-release-arm
/test ocp-full-conformance-rhel-eus
/test ocp-full-conformance-serial-rhel-eus
/test test-rpm
/test test-unit
/test verify

The following commands are available to trigger optional jobs:

/test images
/test security
/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests
pull-ci-openshift-microshift-main-e2e-aws-tests-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm
pull-ci-openshift-microshift-main-images
pull-ci-openshift-microshift-main-security
pull-ci-openshift-microshift-main-test-unit
pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vanhalenar
Copy link
Contributor Author

/test e2e-aws-tests-bootc

@vanhalenar
Copy link
Contributor Author

/test e2e-aws-tests-bootc

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025

@vanhalenar: This pull request references USHIFT-6141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

This is a very basic smoke test. I will be adding one more test to this - deploying a NetworkNodePolicy and checking if the VFs are configured correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2025
@vanhalenar
Copy link
Contributor Author

/test e2e-aws-tests-bootc

@vanhalenar
Copy link
Contributor Author

/test e2e-aws-tests-bootc

@vanhalenar
Copy link
Contributor Author

/test e2e-aws-tests-bootc

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 1, 2025

@vanhalenar: This pull request references USHIFT-6141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

This test is deploying a NetworkNodePolicy and checking if the VFs are configured correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vanhalenar
Copy link
Contributor Author

/test e2e-aws-tests-bootc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

@vanhalenar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc 4bd176e link true /test e2e-aws-tests-bootc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Create VFs And Verify
[Documentation] Deploys sriovnetworknodepolicy and verifies the VF configuration
VAR ${testcmd}= oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
VAR ${testcmd}= oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json
VAR ${testcmd}= oc get sriovnetworknodestate -n sriov-network-operator -o json

because you already have -o json this change won't affect the behaviour

VAR ${testcmd}= oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json
Run With Kubeconfig ${testcmd}
VAR ${cmd}=
... oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json | jq -r '.items[].status.interfaces[0].pciAddress'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
... oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json | jq -r '.items[].status.interfaces[0].pciAddress'
... oc get sriovnetworknodestate -n sriov-network-operator -o json | jq -r '.items[].status.interfaces[0].pciAddress'

prepare_kickstart host1 kickstart-bootc.ks.template rhel96-bootc-source-optionals
# Two nics - one for macvlan, another for ipvlan (they cannot enslave the same interface)
launch_vm --boot_blueprint rhel96-bootc --network "${VM_MULTUS_NETWORK},${VM_MULTUS_NETWORK}"
launch_vm --boot_blueprint rhel96-bootc --network "sriov,${VM_MULTUS_NETWORK},${VM_MULTUS_NETWORK}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a variable for sriov network name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants